Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't avoid sys/types.h when building for Windows #27098

Closed
wants to merge 1 commit into from

Conversation

fanquake
Copy link
Member

We've already used it unguarded in httpserver.cpp for years, with no build issues.

Doesn't touch the usage in wallet/bdb.cpp. See #26832.

We've already used it unguarded in `httpserver.cpp` for years, with no
build issues.
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@hebasto
Copy link
Member

hebasto commented Feb 14, 2023

don't avoid sys/types.h on when building for Windows

Do Windows builds require any symbols from <sys/types.h>? If not, why churn the code?

@fanquake
Copy link
Member Author

Does Windows builds require any symbols from <sys/types.h>?

Aside from ultimately removing pointless per-platform conditionals,

See #26832.

@maflcko maflcko changed the title refactor: don't avoid sys/types.h on when building for Windows refactor: don't avoid sys/types.h when building for Windows Feb 14, 2023
@hebasto
Copy link
Member

hebasto commented Feb 14, 2023

Aside from ultimately removing pointless per-platform conditionals,

But this change does not remove per-platform conditionals.

See #26832.

Yes, I agree with cc16ab1 from #26832.

@fanquake
Copy link
Member Author

But this change does not remove per-platform conditionals.

Yea, that's because this is a step towards doing so.

@fanquake
Copy link
Member Author

Just going to combine this into #26832.

@fanquake fanquake closed this Feb 17, 2023
@fanquake fanquake deleted the windows_can_use_sys_types branch February 17, 2023 14:39
@bitcoin bitcoin locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants