New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: introduce block tracker to retry to download blocks after failure #27837
base: master
Are you sure you want to change the base?
net: introduce block tracker to retry to download blocks after failure #27837
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Maybe mark as draft if CI is red and this is still based on something else? |
Oh, didn't know about the CI failure. Seems to be just an unused variable. But sure, draft until #27836 sounds good. |
1311875
to
aab7a2f
Compare
aab7a2f
to
4d65b99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Focus is on #28170, which is quite close.
Will rebase it as soon as it is merged.
4d65b99
to
7eb78f3
Compare
7eb78f3
to
77fff41
Compare
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the Possibly this is due to a silent merge conflict (the changes in this pull request being Leave a comment here, if you need help tracking down a confusing failure. |
77fff41
to
ab0d925
Compare
Could turn into a draft while CI is red? |
ab0d925
to
ad4fc1b
Compare
ad4fc1b
to
3c7fd2c
Compare
If the initial block fetching process fails, the p2p layer will be in charge of fetching the block from 'any' connected peer. Re-trying to download the block from different peers until it is received.
If no 'peer_id' is provided, 'getblockfrompeer' will just delegate the peer selection to the internal block downloading logic.
Allowing what we had before, a single block request with no automatic retry nor tracking mechanism.
3c7fd2c
to
fdab5b8
Compare
Coming from #27652, part of #29183.
The general idea is to keep track of the user requested blocks so, in
case of a bad behaving peer or a network disconnection, they can be
fetched from another one automatically without any further user interaction.
This was requested by users because the
getblockfrompeer
RPC commandlacks the functionality to notify them about block request failures or peer
disconnections (which is expected due to the asynchronous nature of the block
requests).
Currently, this new functionality is limited to blocks requested by the
user via the 'getblockfrompeer' RPC command.
In the future, this class could expand its scope and be utilized in the
regular chain synchronization process. Or, even could be employed in
special procedures like a prune node rescan that uses BIP158 block filters,
or even into BIP157 itself.