Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fuzz on macOS #27932

Merged
merged 1 commit into from Jun 29, 2023
Merged

test: Fuzz on macOS #27932

merged 1 commit into from Jun 29, 2023

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jun 22, 2023

Any reason not to?

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 22, 2023 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK jamesob, dergoegge
Concept ACK brunoerg, kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Jun 22, 2023
@maflcko maflcko mentioned this pull request Jun 22, 2023
Closed
@maflcko maflcko changed the title test: Run fuzz tests on macOS test: Run fuzz on macOS Jun 22, 2023
@maflcko maflcko changed the title test: Run fuzz on macOS test: Fuzz on macOS Jun 22, 2023
@maflcko
Copy link
Member Author

maflcko commented Jun 22, 2023

Looks like this fails https://cirrus-ci.com/task/6065266690359296?logs=ci#L3616

Run banman with args ['/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-arm64-apple-darwin/src/test/fuzz/fuzz', PosixPath('/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/banman')]Assertion failed: (banmap == banmap_read), function banman_fuzz_target, file banman.cpp, line 112.
Error processing input "/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/banman/f02775f613ebc1b9ff595d4b3129407deac65bfc"
Assertion failed: (banmap == banmap_read), function banman_fuzz_target, file banman.cpp, line 112.
Error processing input "/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/banman/f02775f613ebc1b9ff595d4b3129407deac65bfc"
Target ['/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-arm64-apple-darwin/src/test/fuzz/fuzz', PosixPath('/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/banman')] failed with exit code 1

@dergoegge
Copy link
Member

Concept ACK

Would there be any value in making this a separate task?

@brunoerg
Copy link
Contributor

Concept ACK

test: Run fuzz tests on macOS
fae7c50 
Also, fix a few bugs:

* Error: RPC command "enumeratesigners" not found in RPC_COMMANDS_SAFE_FOR_FUZZING or RPC_COMMANDS_NOT_SAFE_FOR_FUZZING. Please update test/fuzz/rpc.cpp.
* in run_once: ...format(" ".join(result.args), ... TypeError: sequence item 2: expected str instance, PosixPath found
@maflcko
Copy link
Member Author

maflcko commented Jun 22, 2023

Would there be any value in making this a separate task?

Not unless there is a benefit.

@kevkevinpal
Copy link
Contributor

Concept ACK

jamesob
jamesob approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@jamesob jamesob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github ACK fae7c50

Adds fuzzing to a new architecture, right? Seems like an easy win?

dergoegge
dergoegge approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK fae7c50

@fanquake fanquake merged commit 3d51f7c into bitcoin:master Jun 29, 2023
15 checks passed
@maflcko maflcko deleted the 2306-fuzz-mac- branch June 29, 2023 14:22
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 30, 2023
@fanquake @sidhujag
Merge bitcoin#27932: test: Fuzz on macOS
ffaac29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesob jamesob jamesob approved these changes

@dergoegge dergoegge dergoegge approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@maflcko @DrahtBot @dergoegge @brunoerg @kevkevinpal @jamesob @fanquake