Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add michagogo to gitian download scripts #2818

Closed
wants to merge 1 commit into from
Closed

Add michagogo to gitian download scripts #2818

wants to merge 1 commit into from

Conversation

Michagogo
Copy link
Contributor

I've been gitian-building lately, and from conversation in #bitcoin-dev on freenode it sounded like people doing that should be listed here. I understand if I'm not well-known enough to be included. If you don't want to include this, that's fine with me. In addition, if you'd like more verification or confirmation of who I am, I'm willing to provide information about my identity to the core dev team upon request.

As I realize I'm not as well-known as the other users on the list, I've weighted myself lower as well.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/dbe33ce0f793478efd1a0a1abf04c5d83ea77aa9 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@luke-jr
Copy link
Member

luke-jr commented Jul 17, 2013

IMO, either the weight needs to be increased or it should wait until there are enough other keys that this makes a difference. At weight 1, I don't think it's possible for gitian-downloader to ever act on it.

@Michagogo
Copy link
Contributor Author

@luke-jr What weight would you suggest? I just didn't really know how much
the community feels that my signature would be meaningful. (note that an
updated PR would need to wait until my computer is back from repair, about
a week or so)

On Wednesday, July 17, 2013, Luke-Jr wrote:

IMO, either the weight needs to be increased or it should wait until there
are enough other keys that this makes a difference. At weight 1, I don't
think it's possible for gitian-downloader to ever act on it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2818#issuecomment-21091327
.

Sent from Gmail Mobile

@luke-jr
Copy link
Member

luke-jr commented Jul 17, 2013

I'm not sure. Just wanted to point that issue out.

@Michagogo
Copy link
Contributor Author

That did occur to me when I submitted this PR, but I don't really know how
much my signature is worth to you guys... If anyone has a suggestion, I'd
like to hear it (if you think I should be in there at all).

On Wednesday, July 17, 2013, Luke-Jr wrote:

I'm not sure. Just wanted to point that issue out.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2818#issuecomment-21091942
.

Sent from Gmail Mobile

@laanwj
Copy link
Member

laanwj commented Sep 21, 2013

ACK with adding Michagogo, I have no idea what weight to assign either though.

@gavinandresen
Copy link
Contributor

Michagogo should have weight eleven. Because it is my favorite number.

@Michagogo
Copy link
Contributor Author

I've updated with Gavin's suggestion, but it looks like it's not showing up here? The commit is at Michagogo@0766e6c.

@Michagogo
Copy link
Contributor Author

Recreated as #3023 because of the issue with the commit not appearing on this PR.

@Michagogo Michagogo closed this Sep 22, 2013
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 5, 2019
* sp: s/signReqeust/signRequest/g

* sp: s/documenation/documentation/
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants