-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitcoin-Qt: save and restore position of debug window #2827
Conversation
I'd prefer factoring out this code to utility functions or an utility class, instead of just copying it. |
@laanwj That IS a good idea, thanks. |
@laanwj Can you take another look :)? |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fc63a85f6deb17504c206796c9d7a87922588986 for binaries and test log. |
ACK on code changes, haven't yet tested |
- move the code for saving and restoring window positions from BitcoinGUI to GUIUtil, make it more generic and also use it for saving/restoring debug window positions
Updated commit-msg and also removed and include from bitcoingui.cpp. |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c431e9f1f03023d216db0ff48d3d598e705c97f9 for binaries and test log. |
@laanwj Did you test the patch yet? |
ACK: tested on OSX. |
Bitcoin-Qt: save and restore position of debug window
to GUIUtil, make it more generic and also use it for saving/restoring
debug window positions
We also could allow this for all other dialogs, if we want, but that is currently not the goal of this pull.