Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin-Qt: save and restore position of debug window #2827

Merged
merged 1 commit into from
Aug 5, 2013
Merged

Bitcoin-Qt: save and restore position of debug window #2827

merged 1 commit into from
Aug 5, 2013

Conversation

Diapolo
Copy link

@Diapolo Diapolo commented Jul 13, 2013

  • move the code for saving and restoring window positions from BitcoinGUI
    to GUIUtil, make it more generic and also use it for saving/restoring
    debug window positions

We also could allow this for all other dialogs, if we want, but that is currently not the goal of this pull.

@laanwj
Copy link
Member

laanwj commented Jul 19, 2013

I'd prefer factoring out this code to utility functions or an utility class, instead of just copying it.

@Diapolo
Copy link
Author

Diapolo commented Jul 19, 2013

@laanwj That IS a good idea, thanks.

@Diapolo
Copy link
Author

Diapolo commented Jul 19, 2013

@laanwj Can you take another look :)?

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fc63a85f6deb17504c206796c9d7a87922588986 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj
Copy link
Member

laanwj commented Jul 20, 2013

ACK on code changes, haven't yet tested

- move the code for saving and restoring window positions from BitcoinGUI
  to GUIUtil, make it more generic and also use it for saving/restoring
  debug window positions
@Diapolo
Copy link
Author

Diapolo commented Jul 29, 2013

Updated commit-msg and also removed and include from bitcoingui.cpp.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c431e9f1f03023d216db0ff48d3d598e705c97f9 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@Diapolo
Copy link
Author

Diapolo commented Aug 5, 2013

@laanwj Did you test the patch yet?

@gavinandresen
Copy link
Contributor

ACK: tested on OSX.

gavinandresen added a commit that referenced this pull request Aug 5, 2013
Bitcoin-Qt: save and restore position of debug window
@gavinandresen gavinandresen merged commit a4ae029 into bitcoin:master Aug 5, 2013
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants