bugfix: throw an error if an invalid parameter is passed to getnetworkhashps RPC #28554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
jlopp
changed the title
jlopp
force-pushed
the
getnetworkhashps_height_validation
branch
from
057b3e0
to
6074de6
Compare
|
reACK 6074de6 |
maflcko
approved these changes
Oct 2, 2023
jlopp
force-pushed
the
getnetworkhashps_height_validation
branch
from
786ba64
to
1fd3715
Compare
luke-jr
approved these changes
Oct 2, 2023
|
reACK 1fd3715 |
|
lgtm ACK 1fd3715 |
jlopp
force-pushed
the
getnetworkhashps_height_validation
branch
from
1fd3715
to
ec54efd
Compare
|
Upon further inspection I realized that the "lookup" nblocks parameter also had insufficient validation so I've added checks to ensure that it's either a positive number or -1. |
jlopp
changed the title
maflcko
reviewed
Oct 3, 2023
maflcko
reviewed
Oct 3, 2023
jlopp
force-pushed
the
getnetworkhashps_height_validation
branch
3 times, most recently
from
7198be5
to
565ad11
Compare
This was referenced Oct 3, 2023
luke-jr
reviewed
Oct 3, 2023
jlopp
force-pushed
the
getnetworkhashps_height_validation
branch
from
565ad11
to
435ff29
Compare
|
Not sure what's going on with the windows build; it failed on a wallet address test with a socket timeout. Seems unrelated to my PR. Looks like it's a known issue. #28509 |
Sjors
approved these changes
Oct 10, 2023
DrahtBot
requested review from
kevkevinpal
and removed request for
kevkevinpal
|
Any further concerns? |
DrahtBot
requested review from
kevkevinpal
and removed request for
kevkevinpal
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Oct 19, 2023
…oint Github-Pull: bitcoin#28554 Rebased-From: 435ff29
jlopp
force-pushed
the
getnetworkhashps_height_validation
branch
from
435ff29
to
9ac114e
Compare
|
Thanks for rebasing. re-utACK 9ac114e |
DrahtBot
requested review from
kevkevinpal
and removed request for
kevkevinpal and
Sjors
|
reACK 9ac114e |
|
ACK 9ac114e |
glozow
pushed a commit
to glozow/bitcoin
that referenced
this pull request
Apr 17, 2024
…oint Github-Pull: bitcoin#28554 Rebased-From: 9ac114e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing some scripts that iterated over many blocks to generate hashrate estimates I realized that my script was going out of range of the current chain tip height but was not encountering any errors.
I believe that passing an invalid block height to this function but receiving the hashrate estimate for the chain tip instead should be considered unexpected behavior.