doc: update BroadcastTransaction comment

[ismaelsadeeq]

BroadcastTransaction is also called by submitpackage RPC.

All transactions that are accepted into the mempool post package processing are broadcasted to peers individually here

bitcoin/src/rpc/mempool.cpp

Line 926 in ea4ddd8

const auto err = BroadcastTransaction(node, tx, err_string, /*max_tx_fee=*/0, /*relay=*/true, /*wait_callback=*/true);

It's not maintainable to list all the callers of a function.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	stickies-v, kristapsk, naumenkogs
Stale ACK	vasild, BrandonOdiwuor, willcl-ark, shaavan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[vasild]

ACK cca20d9

I was looking at the same comment and was thinking it needs an update. Thanks!

[BrandonOdiwuor]

lgtm ACK cca20d9

[kristapsk]

ACK cca20d9

[willcl-ark]

ACK cca20d9

[shaavan]

ACK 437e8eb

Following the discussion in the PR so far, I agree that it is more logical and maintainable not to detail which function calls (or can call) a particular function since this information is easily accessible through other methods (e.g. by using an IDE)
That's why I think it's best to remove the comment.

[stickies-v]

ACK 31cce4a

[kristapsk]

ACK 31cce4a

[naumenkogs]

ACK 31cce4a