test: assert rpc error for addnode v2transport not enabled #29460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added coverage for the addnode rpc when v2transport is not enabled but is set as true when calling addnode rpc
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
lgtm ACK 345169a
Checked coverage per https://corecheck.dev/bitcoin/bitcoin/pulls/29460
| @@ -12,6 +12,7 @@ | |||
| from test_framework.util import ( | |||
| assert_equal, | |||
| p2p_port, | |||
| assert_raises_rpc_error | |||
There was a problem hiding this comment.
Suggested change
| assert_raises_rpc_error | |
| assert_raises_rpc_error, |
nit (only if you re-touch for other reasons): Please always add the trailing comma, to avoid having to touch this line again in the future when a new item is added to the list. Also, could sort.
brunoerg
approved these changes
Feb 21, 2024
BrandonOdiwuor
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added coverage for the
addnoderpc when v2transport is not enabled,but is set as true when calling
addnoderpc.I ran the following to check if this rpc error message
was covered in the functional tests.
grep -nr "v2transport requested but not enabled" ./test/functional --binary-files=without-matchAdds test coverage to this line.
https://github.com/bitcoin/bitcoin/blob/master/src/rpc/net.cpp#L339