Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy: remove todo, set minimum CMake to 3.22 #29696

Merged
merged 4 commits into from
Mar 25, 2024
Merged

tidy: remove todo, set minimum CMake to 3.22 #29696

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24410e5
tidy: set minimum CMake to 3.22
fanquake Mar 21, 2024
5b690ae
tidy: remove terminfo TODO
fanquake Mar 21, 2024
c3a4ea1
tidy: set CMAKE_CXX_STANDARD to 20
fanquake Mar 22, 2024
11ee058
tidy: remove C compiler check
fanquake Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 15 additions & 4 deletions contrib/devtools/bitcoin-tidy/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,25 @@
cmake_minimum_required(VERSION 3.9)
cmake_minimum_required(VERSION 3.22)

project(bitcoin-tidy VERSION 1.0.0 DESCRIPTION "clang-tidy checks for Bitcoin Core")
project(bitcoin-tidy
VERSION
1.0.0
DESCRIPTION "clang-tidy checks for Bitcoin Core"
LANGUAGES CXX)

include(GNUInstallDirs)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED True)
set(CMAKE_CXX_EXTENSIONS False)

# TODO: Figure out how to avoid the terminfo check
set(CMAKE_DISABLE_FIND_PACKAGE_CURL ON)
hebasto marked this conversation as resolved.
Show resolved Hide resolved
set(CMAKE_DISABLE_FIND_PACKAGE_FFI ON)
set(CMAKE_DISABLE_FIND_PACKAGE_LibEdit ON)
set(CMAKE_DISABLE_FIND_PACKAGE_LibXml2 ON)
set(CMAKE_DISABLE_FIND_PACKAGE_Terminfo ON)
set(CMAKE_DISABLE_FIND_PACKAGE_ZLIB ON)
set(CMAKE_DISABLE_FIND_PACKAGE_zstd ON)

find_package(LLVM REQUIRED CONFIG)
find_program(CLANG_TIDY_EXE NAMES "clang-tidy-${LLVM_VERSION_MAJOR}" "clang-tidy" HINTS ${LLVM_TOOLS_BINARY_DIR})
message(STATUS "Found LLVM ${LLVM_PACKAGE_VERSION}")
Expand Down