test: check disconnection when sending sendaddrv2 after verack #29699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
|
lgtm ACK 8517ee9 |
|
ACK 8517ee9 |
maflcko
reviewed
Mar 27, 2024
brunoerg
force-pushed
the
2024-03-test-sendaddrv2-after-verack
branch
from
8517ee9
to
6a37493
Compare
brunoerg
force-pushed
the
2024-03-test-sendaddrv2-after-verack
branch
from
6a37493
to
b4c9ace
Compare
|
Force-pushed addressing #29699 (comment) |
byaye
approved these changes
Apr 15, 2024
|
lgtm ACK b4c9ace |
glozow
reviewed
Apr 15, 2024
Comment on lines
-92
to
+100
| f'received: addrv2 ({msg_size} bytes) peer=0', | ||
| f'sending addrv2 ({msg_size} bytes) peer=1', | ||
| f'received: addrv2 ({msg_size} bytes) peer=1', | ||
| f'sending addrv2 ({msg_size} bytes) peer=2', |
There was a problem hiding this comment.
(I think this is a good example of why we shouldn't use assert_debug_log when we're able to check the logic otherwise)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for:
bitcoin/src/net_processing.cpp
Lines 3796 to 3807 in 71b6319