ci: Add missing -Wno-error=maybe-uninitialized to armhf task #30144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This was referenced May 21, 2024
|
utACK fa73431 |
cbergqvist
reviewed
May 21, 2024
| @@ -17,4 +17,4 @@ export RUN_FUNCTIONAL_TESTS=false | |||
| export GOAL="install" | |||
| # -Wno-psabi is to disable ABI warnings: "note: parameter passing for argument of type ... changed in GCC 7.1" | |||
| # This could be removed once the ABI change warning does not show up by default | |||
| export BITCOIN_CONFIG="--enable-reduce-exports CXXFLAGS=-Wno-psabi" | |||
| export BITCOIN_CONFIG="--enable-reduce-exports CXXFLAGS='-Wno-psabi -Wno-error=maybe-uninitialized'" | |||
There was a problem hiding this comment.
Good to see. Might be worth adding a comment about why the warning is disabled here and in ci/test/00_setup_env_win64.sh?
There was a problem hiding this comment.
All -Wno-error= in ./ci/ are due to false positives. I may address this, if I have to re-push for other reasons.
|
lgtm |
|
Ported to the CMake-based build system in hebasto#207. |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 22, 2024
4b9b5c5 fixup! ci: Migrate CI scripts to CMake (Hennadii Stepanov) Pull request description: This PR ports bitcoin#30144. Top commit has no ACKs. Tree-SHA512: 56f3f4fc7408b1fa9887e979bf15de5ea7e8fe56d6e5194bfeaa862c164bf8f4d9259b4ae0121af8f4f4dbd6a43f23e82948fa6bac21175a0ba365d0d47bfd03
maflcko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens after bd597c3 in many pull requests as a silent merge conflict. For example: