Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'low S' as malleability breaker rather than 'even S' #3016

Merged
merged 1 commit into from
Sep 23, 2013

Conversation

sipa
Copy link
Member

@sipa sipa commented Sep 18, 2013

As we don't have any releases enforcing this yet, and no others that have picked it up, we can change this without harm. It has the advantage of on average decreasing signatures by 0.5 byte, and avoiding DER padding problems.

@gmaxwell
Copy link
Contributor

Pieter and I had discussed this a few weeks ago before his vacation.

ACK code, also, I ran 30,000 signatures through this and confirmed that the average signature size is reduced by 0.5 byte, the maximum is reduced by 1 byte, and all 30,000 resulting signatures validated.

@gavinandresen
Copy link
Contributor

ACK

@gavinandresen
Copy link
Contributor

Ignore pull-tester errors for now, I'm debugging it...

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e0e14e43d9586409e42919f6cb955540134cda2a for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

sipa added a commit that referenced this pull request Sep 23, 2013
Use 'low S' as malleability breaker rather than 'even S'
@sipa sipa merged commit a28fb70 into bitcoin:master Sep 23, 2013
metalicjames added a commit to metalicjames/bitcoin that referenced this pull request Feb 16, 2017
This commit does the same this as this pull: request bitcoin#3016

This is in preparation for a lowS signature enforcement policy coming in the next version
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 8, 2020
Merge master 0.14.0.2 back into develop
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants