Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc, rpc: Release notes and follow-ups for #29612 #30167

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

fjahr
Copy link
Contributor

@fjahr fjahr commented May 24, 2024

This adds release notes for #29612 and addresses post-merge review comments.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 24, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, theStack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, apart from the assert

src/test/util/chainstate.h Outdated Show resolved Hide resolved
src/node/utxo_snapshot.h Outdated Show resolved Hide resolved
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK efc1b5b

@Sjors
Copy link
Member

Sjors commented May 28, 2024

I checked that efc1b5b still gives me the same snapshot as the last the time I reviewed #29612.

@fanquake
Copy link
Member

@theStack or @TheCharlatan want to have a look over the followup?

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK efc1b5b

Comment on lines +4 to +5
- The `dumptxoutset` RPC now returns the UTXO set dump in a new and
improved format. At the same time the `loadtxoutset` RPC now
Copy link
Contributor

@theStack theStack Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not a must, but it could be interesting for users to know what exactly has improved with the new format (i.e. more space-efficient, enhanced metadata, enabling more detailed error messages etc.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make any further release note additions when the notes are consolidated / merged into the wiki.

@fanquake fanquake merged commit 80bdd4b into bitcoin:master Jun 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants