-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc, rpc: Release notes and follow-ups for #29612 #30167
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, apart from the assert
This prevents SnapshotMetadata from using any globals implicitly.
c6c70e5
to
efc1b5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK efc1b5b
@theStack or @TheCharlatan want to have a look over the followup? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK efc1b5b
- The `dumptxoutset` RPC now returns the UTXO set dump in a new and | ||
improved format. At the same time the `loadtxoutset` RPC now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not a must, but it could be interesting for users to know what exactly has improved with the new format (i.e. more space-efficient, enhanced metadata, enabling more detailed error messages etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make any further release note additions when the notes are consolidated / merged into the wiki.
This adds release notes for #29612 and addresses post-merge review comments.