Win signed cleanup ideal #6343
Closed
Win signed cleanup ideal #6343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michagogo
force-pushed
the
win-signed-cleanup-ideal
branch
from
41c917d
to
301d7c7
Compare
This is an ideal version of what the release process should look like, making it more consistent with the OS X process. Some of the changes described here would need to be made in the descriptors, which is somewhat beyond what I would feel comfortable doing, not really understanding the signature process in depth. [skip ci]
Michagogo
force-pushed
the
win-signed-cleanup-ideal
branch
from
301d7c7
to
f3c3b21
Compare
|
Closing in favor of #6354 which includes this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6342: this PR is the ideal, what should eventually be merged. However, it cannot be merged yet. The following changes would need to be made first by someone else (@theuni?):
gitian-win.ymlwould need to be changed to output one single tarball with everything needed for the signing, as in the OS X processgitian-win-signer.ymlwould need to be changed to use said tarballgitian-win.ymlwould need to be changed to include -unsigned in the installer file names