Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QT] fix thin space word wrap line brake issue #6694

Merged
merged 1 commit into from
Sep 22, 2015

Conversation

jonasschnelli
Copy link
Contributor

The thin space QT html hack results in cut-off chars/nums after a line break.
Avoid word wrap line breaks by using a smaller font and a line break before each alternative value).

bildschirmfoto 2015-09-18 um 13 48 49

The thin space QT html hack results in cut-off chars/nums after a line break.

Avoid word wrap line breaks by using a smaller font and a line break before each alternative value)
@jonasschnelli
Copy link
Contributor Author

Fixes #6683
Bug introduced in #4167

@laanwj
Copy link
Member

laanwj commented Sep 18, 2015

utACK needs backport to 0.11 and possibly 0.10

@jonasschnelli
Copy link
Contributor Author

Binaries:
https://bitcoin.jonasschnelli.ch/pulls/6694/

Linux Gitian/QT5:
bildschirmfoto 2015-09-18 um 16 08 59

Windows:
bildschirmfoto 2015-09-18 um 16 10 20

@maflcko
Copy link
Member

maflcko commented Sep 20, 2015

Can't reproduce on fedora 23, GNOME. Concept ACK, though.

@laanwj laanwj merged commit 24cb7c7 into bitcoin:master Sep 22, 2015
laanwj added a commit that referenced this pull request Sep 22, 2015
24cb7c7 [QT] fix thin space word wrap line brake issue (Jonas Schnelli)
laanwj pushed a commit that referenced this pull request Sep 22, 2015
The thin space QT html hack results in cut-off chars/nums after a line break.

Avoid word wrap line breaks by using a smaller font and a line break before each alternative value)

Rebased-From: 24cb7c7
Github-Pull: #6694
laanwj pushed a commit that referenced this pull request Sep 22, 2015
The thin space QT html hack results in cut-off chars/nums after a line break.

Avoid word wrap line breaks by using a smaller font and a line break before each alternative value)

Rebased-From: 24cb7c7
Github-Pull: #6694
@laanwj
Copy link
Member

laanwj commented Sep 22, 2015

Backported to 0.11 as 834e299, to 0.10 as f696ea1

reddink pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request May 27, 2020
The thin space QT html hack results in cut-off chars/nums after a line break.

Avoid word wrap line breaks by using a smaller font and a line break before each alternative value)

Rebased-From: 24cb7c7
Github-Pull: bitcoin#6694
(cherry picked from commit f696ea1)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants