Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timedata: Prevent warning overkill #6728

Merged
merged 1 commit into from Sep 29, 2015
Merged

Conversation

@laanwj
Copy link
Member

laanwj commented Sep 27, 2015

The "please check your computer's data and time" message when the clock deviates from the network currently generates an overkill of messages :-)

orion@lethe:~/bitcoin$ src/bitcoind
Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

In the log:

2015-09-27 16:24:13 *** Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
2015-09-27 16:24:13 Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

Remove one level of 'Warning:' and reduce to one log message.

Edit: An open question is whether this message should be translated at all, currently it is.

The "please check your computer's data and time" message when the clock
deviates from the network currently generates an overkill of messages:

    orion@lethe:~/bitcoin$ src/bitcoind
    Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

In the log:

    2015-09-27 16:24:13 *** Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
    2015-09-27 16:24:13 Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

Remove one level of 'Warning:' and reduce to one log message.
@laanwj laanwj added the Trivial label Sep 27, 2015
@fanquake
Copy link
Member

fanquake commented Sep 28, 2015

ACK

@jonasschnelli
Copy link
Member

jonasschnelli commented Sep 28, 2015

utACK.

@MarcoFalke
Copy link
Member

MarcoFalke commented Sep 28, 2015

Tested ACK 9fea833 on fed23 with bitcoind.

Though, QT will crash (regardless of this PR).

@jonasschnelli
Copy link
Member

jonasschnelli commented Sep 28, 2015

Though, QT will crash (regardless of this PR).

Can you explain that more detailed? Why is QT crashing?

@fanquake
Copy link
Member

fanquake commented Sep 28, 2015

Probably better to open a separate issue, if there isn't one already.

On Monday, September 28, 2015, Jonas Schnelli notifications@github.com
wrote:

Though, QT will crash (regardless of this PR).

Can you explain that more detailed? Why is QT crashing?


Reply to this email directly or view it on GitHub
#6728 (comment).

@jonasschnelli
Copy link
Member

jonasschnelli commented Sep 28, 2015

Could not crash Fedora and OSX when set my local date +2 day and did 5min IBD on testnet.

@MarcoFalke
Copy link
Member

MarcoFalke commented Sep 28, 2015

Fedora 23 is alpha, so likely it's a local issue with modal dialogs on my box. Doesn't hold back this PR.

@ongygy2000
Copy link

ongygy2000 commented Sep 28, 2015

date and time are correct but still load core bitcoin network
Thanks for the loyalty of the cooperation

@laanwj
Copy link
Member Author

laanwj commented Sep 29, 2015

A GUI crash is a serious issue, however please open a new issue for that with more information: debug.log tail, any messages, traceback if possible. It cannot be related to the trivial message change here.

@laanwj laanwj merged commit 9fea833 into bitcoin:master Sep 29, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Sep 29, 2015
9fea833 timedata: Prevent warning overkill (Wladimir J. van der Laan)
@MarcoFalke
Copy link
Member

MarcoFalke commented Oct 29, 2015

Can no longer reproduce the GUI crash...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.