timedata: Prevent warning overkill #6728

Merged
merged 1 commit into from Sep 29, 2015

Conversation

Projects
None yet
5 participants
@laanwj
Member

laanwj commented Sep 27, 2015

The "please check your computer's data and time" message when the clock deviates from the network currently generates an overkill of messages :-)

orion@lethe:~/bitcoin$ src/bitcoind
Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

In the log:

2015-09-27 16:24:13 *** Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
2015-09-27 16:24:13 Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

Remove one level of 'Warning:' and reduce to one log message.

Edit: An open question is whether this message should be translated at all, currently it is.

timedata: Prevent warning overkill
The "please check your computer's data and time" message when the clock
deviates from the network currently generates an overkill of messages:

    orion@lethe:~/bitcoin$ src/bitcoind
    Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

In the log:

    2015-09-27 16:24:13 *** Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
    2015-09-27 16:24:13 Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

Remove one level of 'Warning:' and reduce to one log message.

@laanwj laanwj added the Trivial label Sep 27, 2015

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Sep 28, 2015

Member

ACK

Member

fanquake commented Sep 28, 2015

ACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Sep 28, 2015

Member

utACK.

Member

jonasschnelli commented Sep 28, 2015

utACK.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Sep 28, 2015

Member

Tested ACK 9fea833 on fed23 with bitcoind.

Though, QT will crash (regardless of this PR).

Member

MarcoFalke commented Sep 28, 2015

Tested ACK 9fea833 on fed23 with bitcoind.

Though, QT will crash (regardless of this PR).

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Sep 28, 2015

Member

Though, QT will crash (regardless of this PR).

Can you explain that more detailed? Why is QT crashing?

Member

jonasschnelli commented Sep 28, 2015

Though, QT will crash (regardless of this PR).

Can you explain that more detailed? Why is QT crashing?

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Sep 28, 2015

Member

Probably better to open a separate issue, if there isn't one already.

On Monday, September 28, 2015, Jonas Schnelli notifications@github.com
wrote:

Though, QT will crash (regardless of this PR).

Can you explain that more detailed? Why is QT crashing?


Reply to this email directly or view it on GitHub
#6728 (comment).

Member

fanquake commented Sep 28, 2015

Probably better to open a separate issue, if there isn't one already.

On Monday, September 28, 2015, Jonas Schnelli notifications@github.com
wrote:

Though, QT will crash (regardless of this PR).

Can you explain that more detailed? Why is QT crashing?


Reply to this email directly or view it on GitHub
#6728 (comment).

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Sep 28, 2015

Member

Could not crash Fedora and OSX when set my local date +2 day and did 5min IBD on testnet.

Member

jonasschnelli commented Sep 28, 2015

Could not crash Fedora and OSX when set my local date +2 day and did 5min IBD on testnet.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Sep 28, 2015

Member

Fedora 23 is alpha, so likely it's a local issue with modal dialogs on my box. Doesn't hold back this PR.

Member

MarcoFalke commented Sep 28, 2015

Fedora 23 is alpha, so likely it's a local issue with modal dialogs on my box. Doesn't hold back this PR.

@ongygy2000

This comment has been minimized.

Show comment
Hide comment
@ongygy2000

ongygy2000 Sep 28, 2015

date and time are correct but still load core bitcoin network
Thanks for the loyalty of the cooperation

date and time are correct but still load core bitcoin network
Thanks for the loyalty of the cooperation

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Sep 29, 2015

Member

A GUI crash is a serious issue, however please open a new issue for that with more information: debug.log tail, any messages, traceback if possible. It cannot be related to the trivial message change here.

Member

laanwj commented Sep 29, 2015

A GUI crash is a serious issue, however please open a new issue for that with more information: debug.log tail, any messages, traceback if possible. It cannot be related to the trivial message change here.

@laanwj laanwj merged commit 9fea833 into bitcoin:master Sep 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 29, 2015

Merge pull request #6728
9fea833 timedata: Prevent warning overkill (Wladimir J. van der Laan)
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Oct 29, 2015

Member

Can no longer reproduce the GUI crash...

Member

MarcoFalke commented Oct 29, 2015

Can no longer reproduce the GUI crash...

@str4d str4d referenced this pull request in zcash/zcash Jul 14, 2017

Open

Bitcoin 0.12 P2P/Net PRs 1 #2534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment