Skip to content

ui: Add "Copy raw transaction data" to transaction list context menu#7051

Merged
laanwj merged 1 commit intobitcoin:masterfrom
laanwj:2015_11_transaction_hex2
Nov 19, 2015
Merged

ui: Add "Copy raw transaction data" to transaction list context menu#7051
laanwj merged 1 commit intobitcoin:masterfrom
laanwj:2015_11_transaction_hex2

Conversation

@laanwj
Copy link
Copy Markdown
Member

@laanwj laanwj commented Nov 18, 2015

Add a way to quickly copy transaction hex to clipboard.

Primarily useful when manually submitting transactions, e.g. -walletbroadcast=0 is set.

copyrawtransactiondata

@laanwj laanwj added the GUI label Nov 18, 2015
@maflcko
Copy link
Copy Markdown
Member

maflcko commented Nov 18, 2015

Concept ACK

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You could get rid of the "data" suffix because "raw transaction" already implies this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Did decide not to use hex as that will give translation issues :-)

@jonasschnelli
Copy link
Copy Markdown
Contributor

Nice! utACK. Will test soon.

@gmaxwell
Copy link
Copy Markdown
Contributor

Neat. Concept ACK.

@jonasschnelli
Copy link
Copy Markdown
Contributor

Tested ACK.

bildschirmfoto 2015-11-18 um 14 20 37

One little thing (not related to this PR):

  • If you select multiple rows in the table and use the context menu, it does affect the column at the very top of the selection (even if you open the context menu "over" another row). I think we should disallow multiple row-selection.

@paveljanik
Copy link
Copy Markdown
Contributor

I like it!

ACK (please remove the "data").

@laanwj laanwj force-pushed the 2015_11_transaction_hex2 branch from a3d9026 to b4f3e9c Compare November 19, 2015 10:08
Add a way to quickly copy transaction hex.

Primarily useful when manually submitting transactions,
e.g. `-walletbroadcast=0` is set.
@maflcko
Copy link
Copy Markdown
Member

maflcko commented Nov 19, 2015

utACK b4f3e9c

@laanwj laanwj merged commit b4f3e9c into bitcoin:master Nov 19, 2015
laanwj added a commit that referenced this pull request Nov 19, 2015
b4f3e9c ui: Add "Copy raw transaction data" to transaction list context menu (Wladimir J. van der Laan)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants