Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add "Copy raw transaction data" to transaction list context menu #7051

Merged
merged 1 commit into from Nov 19, 2015

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Nov 18, 2015

Add a way to quickly copy transaction hex to clipboard.

Primarily useful when manually submitting transactions, e.g. -walletbroadcast=0 is set.

copyrawtransactiondata

@laanwj laanwj added the GUI label Nov 18, 2015
@MarcoFalke
Copy link
Member

MarcoFalke commented Nov 18, 2015

Concept ACK

@@ -141,6 +141,7 @@ TransactionView::TransactionView(const PlatformStyle *platformStyle, QWidget *pa
QAction *copyLabelAction = new QAction(tr("Copy label"), this);
QAction *copyAmountAction = new QAction(tr("Copy amount"), this);
QAction *copyTxIDAction = new QAction(tr("Copy transaction ID"), this);
QAction *copyTxHexAction = new QAction(tr("Copy raw transaction data"), this);
Copy link
Member

@MarcoFalke MarcoFalke Nov 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You could get rid of the "data" suffix because "raw transaction" already implies this.

Copy link
Member Author

@laanwj laanwj Nov 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Did decide not to use hex as that will give translation issues :-)

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Nov 18, 2015

Nice! utACK. Will test soon.

@gmaxwell
Copy link
Contributor

gmaxwell commented Nov 18, 2015

Neat. Concept ACK.

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Nov 18, 2015

Tested ACK.

bildschirmfoto 2015-11-18 um 14 20 37

One little thing (not related to this PR):

  • If you select multiple rows in the table and use the context menu, it does affect the column at the very top of the selection (even if you open the context menu "over" another row). I think we should disallow multiple row-selection.

@paveljanik
Copy link
Contributor

paveljanik commented Nov 18, 2015

I like it!

ACK (please remove the "data").

@laanwj laanwj force-pushed the 2015_11_transaction_hex2 branch from a3d9026 to b4f3e9c Compare Nov 19, 2015
Add a way to quickly copy transaction hex.

Primarily useful when manually submitting transactions,
e.g. `-walletbroadcast=0` is set.
@MarcoFalke
Copy link
Member

MarcoFalke commented Nov 19, 2015

utACK b4f3e9c

@laanwj laanwj merged commit b4f3e9c into bitcoin:master Nov 19, 2015
laanwj added a commit that referenced this pull request Nov 19, 2015
b4f3e9c ui: Add "Copy raw transaction data" to transaction list context menu (Wladimir J. van der Laan)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants