ui: Add "Copy raw transaction data" to transaction list context menu #7051

Merged
merged 1 commit into from Nov 19, 2015

Conversation

Projects
None yet
5 participants
@laanwj
Member

laanwj commented Nov 18, 2015

Add a way to quickly copy transaction hex to clipboard.

Primarily useful when manually submitting transactions, e.g. -walletbroadcast=0 is set.

copyrawtransactiondata

@laanwj laanwj added the GUI label Nov 18, 2015

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Nov 18, 2015

Member

Concept ACK

Member

MarcoFalke commented Nov 18, 2015

Concept ACK

@MarcoFalke

View changes

src/qt/transactionview.cpp
@@ -141,6 +141,7 @@ TransactionView::TransactionView(const PlatformStyle *platformStyle, QWidget *pa
QAction *copyLabelAction = new QAction(tr("Copy label"), this);
QAction *copyAmountAction = new QAction(tr("Copy amount"), this);
QAction *copyTxIDAction = new QAction(tr("Copy transaction ID"), this);
+ QAction *copyTxHexAction = new QAction(tr("Copy raw transaction data"), this);

This comment has been minimized.

@MarcoFalke

MarcoFalke Nov 18, 2015

Member

Nit: You could get rid of the "data" suffix because "raw transaction" already implies this.

@MarcoFalke

MarcoFalke Nov 18, 2015

Member

Nit: You could get rid of the "data" suffix because "raw transaction" already implies this.

This comment has been minimized.

@laanwj

laanwj Nov 18, 2015

Member

Sounds good to me. Did decide not to use hex as that will give translation issues :-)

@laanwj

laanwj Nov 18, 2015

Member

Sounds good to me. Did decide not to use hex as that will give translation issues :-)

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Nov 18, 2015

Member

Nice! utACK. Will test soon.

Member

jonasschnelli commented Nov 18, 2015

Nice! utACK. Will test soon.

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Nov 18, 2015

Member

Neat. Concept ACK.

Member

gmaxwell commented Nov 18, 2015

Neat. Concept ACK.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Nov 18, 2015

Member

Tested ACK.

bildschirmfoto 2015-11-18 um 14 20 37

One little thing (not related to this PR):

  • If you select multiple rows in the table and use the context menu, it does affect the column at the very top of the selection (even if you open the context menu "over" another row). I think we should disallow multiple row-selection.
Member

jonasschnelli commented Nov 18, 2015

Tested ACK.

bildschirmfoto 2015-11-18 um 14 20 37

One little thing (not related to this PR):

  • If you select multiple rows in the table and use the context menu, it does affect the column at the very top of the selection (even if you open the context menu "over" another row). I think we should disallow multiple row-selection.
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Nov 18, 2015

Contributor

I like it!

ACK (please remove the "data").

Contributor

paveljanik commented Nov 18, 2015

I like it!

ACK (please remove the "data").

ui: Add "Copy raw transaction data" to transaction list context menu
Add a way to quickly copy transaction hex.

Primarily useful when manually submitting transactions,
e.g. `-walletbroadcast=0` is set.
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
Member

MarcoFalke commented Nov 19, 2015

utACK b4f3e9c

@laanwj laanwj merged commit b4f3e9c into bitcoin:master Nov 19, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

laanwj added a commit that referenced this pull request Nov 19, 2015

Merge pull request #7051
b4f3e9c ui: Add "Copy raw transaction data" to transaction list context menu (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment