ui: Add "Copy raw transaction data" to transaction list context menu #7051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
| @@ -141,6 +141,7 @@ TransactionView::TransactionView(const PlatformStyle *platformStyle, QWidget *pa | |||
| QAction *copyLabelAction = new QAction(tr("Copy label"), this); | |||
| QAction *copyAmountAction = new QAction(tr("Copy amount"), this); | |||
| QAction *copyTxIDAction = new QAction(tr("Copy transaction ID"), this); | |||
| QAction *copyTxHexAction = new QAction(tr("Copy raw transaction data"), this); | |||
There was a problem hiding this comment.
Nit: You could get rid of the "data" suffix because "raw transaction" already implies this.
There was a problem hiding this comment.
Sounds good to me. Did decide not to use hex as that will give translation issues :-)
|
Nice! utACK. Will test soon. |
|
Neat. Concept ACK. |
|
Tested ACK.
One little thing (not related to this PR):
|
|
I like it! ACK (please remove the "data"). |
laanwj
force-pushed
the
2015_11_transaction_hex2
branch
from
a3d9026
to
b4f3e9c
Compare
Add a way to quickly copy transaction hex. Primarily useful when manually submitting transactions, e.g. `-walletbroadcast=0` is set.
|
utACK b4f3e9c |
laanwj
added a commit
that referenced
this pull request
Nov 19, 2015
b4f3e9c ui: Add "Copy raw transaction data" to transaction list context menu (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to quickly copy transaction hex to clipboard.
Primarily useful when manually submitting transactions, e.g.
-walletbroadcast=0is set.