Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Correctly calculate priority when inputs are mined after dependent transactions enter the memory pool #7149

Closed
wants to merge 9 commits into from
Closed

Bugfix: Correctly calculate priority when inputs are mined after dependent transactions enter the memory pool #7149

wants to merge 9 commits into from

Commits on Nov 16, 2016

  1. Add GetStartingPriority method to reliably get the original priority … 

    …of a transaction in the mempool
    @morcos @luke-jr
    morcos authored and luke-jr committed Nov 16, 2016
    Copy the full SHA
    c6c89bb View commit details
    Browse the repository at this point in the history

  2. Change GetPriority calculation to dynamically update 

    Track the value of inputs that get confirmed in the chain and keep a cached value of priority at a given height and return current priority by only assuming these in chain inputs are aging.
    @morcos @luke-jr
    morcos authored and luke-jr committed Nov 16, 2016
    Copy the full SHA
    8aa1ae2 View commit details
    Browse the repository at this point in the history

  3. Add consistency check for on the fly priority calculations

    @morcos @luke-jr
    morcos authored and luke-jr committed Nov 16, 2016
    Copy the full SHA
    98ef483 View commit details
    Browse the repository at this point in the history

  4. QA: Add test for priority via getrawmempool

    @luke-jr
    luke-jr committed Nov 16, 2016
    Copy the full SHA
    2d72888 View commit details
    Browse the repository at this point in the history

  5. QA: Enable testing priority via getblocktemplate as well

    @luke-jr
    luke-jr committed Nov 16, 2016
    Copy the full SHA
    cc260ed View commit details
    Browse the repository at this point in the history

  6. QA: Extend txn_priority test to check across a reorganisation

    @luke-jr
    luke-jr committed Nov 16, 2016
    Copy the full SHA
    6704f5b View commit details
    Browse the repository at this point in the history

  7. Bugfix: Correct off-by-one errors in getrawmempool startingpriority a… 

    …nd currentpriority

- Since the transaction arrives after block N, its starting priority is that for block N+1.
- The current priority is likewise as considered for mining the next block.
    @luke-jr
    luke-jr committed Nov 16, 2016
    Copy the full SHA
    92c18a4 View commit details
    Browse the repository at this point in the history

  8. Bugfix: rpc-tests/txn_priority: When connecting disconnected nodes, t… 

    …heir mempools may not sync, so only sync blocks
    @luke-jr
    luke-jr committed Nov 16, 2016
    Copy the full SHA
    fab562b View commit details
    Browse the repository at this point in the history

  9. CTxMemPool::check: Use height+1 for priority comparison, since height… 

    … is not guaranteed to work
    @luke-jr
    luke-jr committed Nov 16, 2016
    Copy the full SHA
    ae93a95 View commit details
    Browse the repository at this point in the history