Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools: show pull and commit information in github-merge #7395

Merged
merged 1 commit into from Jan 25, 2016

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Jan 22, 2016

Print the number and title of the pull, as well as the commits to be merged.

Example:
pullinfo

Print the number and title of the pull, as well as the commits to be
merged.
@jonasschnelli
Copy link
Contributor

Oh. Nice!

Tested ACK:
bildschirmfoto 2016-01-22 um 16 55 30
libbtc/libbtc@a56ea73

@fanquake
Copy link
Member

utACK

On Friday, 22 January 2016, Jonas Schnelli notifications@github.com wrote:

Oh. Nice!

Tested ACK:
[image: bildschirmfoto 2016-01-22 um 16 55 30]
https://cloud.githubusercontent.com/assets/178464/12515509/1527d274-c129-11e5-8072-43df09e026f6.png
libbtc/libbtc@a56ea73
libbtc/libbtc@a56ea73


Reply to this email directly or view it on GitHub
#7395 (comment).

@achow101
Copy link
Member

Tested ACK 17b5d38

Although it still has the bug that I fixed in #7402 which was in the original.

@laanwj
Copy link
Member Author

laanwj commented Jan 25, 2016

@achow101 Yes, the python version is a direct conversion of the bash script, I don't expect it to solve any bugs, just make it easier to add features. I'll have a look at #7402 and include that.

Edit: OH, that's a patch to the python version already and independent of this, I'll just merge that too.

@laanwj laanwj merged commit 17b5d38 into bitcoin:master Jan 25, 2016
laanwj added a commit that referenced this pull request Jan 25, 2016
17b5d38 devtools: show pull and commit information in github-merge (Wladimir J. van der Laan)
codablock pushed a commit to codablock/dash that referenced this pull request Dec 9, 2017
…hub-merge

17b5d38 devtools: show pull and commit information in github-merge (Wladimir J. van der Laan)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants