build: python 3 compatibility #7723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
force-pushed
the
2016_03_build_python_3
branch
2 times, most recently
from
076dab8
to
40a9d86
Compare
|
Ping @theuni |
|
Looks good. Concept ACK 40a9d86 |
|
Concept ACK. Why not use |
laanwj
force-pushed
the
2016_03_build_python_3
branch
from
40a9d86
to
b875273
Compare
Interpeter shouldn't matter anymore because all usages invoke the explicitly located python executable. |
|
@laanwj Aha, clever fix :) I'm not well-versed in python2/python3 to comment on the compat there, but concept ack for sure. Looks like some of the mac deploy scripts are missing, though: Those both get hit via |
Right, good catch, will have a look at those. |
laanwj
force-pushed
the
2016_03_build_python_3
branch
from
9cd0105
to
b40e365
Compare
|
@cfields see b40e365c2a24019e2b3e2651510874d0cecf2ae3 |
Ok, tested by temporarily changing the detection to only 'see' python3. It passed. |
laanwj
force-pushed
the
2016_03_build_python_3
branch
from
bff30d0
to
b40e365
Compare
| @@ -575,7 +575,7 @@ if len(config.fancy) == 1: | |||
| if fancy.has_key("background_picture"): | |||
There was a problem hiding this comment.
Nit: there is no has_key in py3
|
utACK b40e365 |
Ubuntu 16.04 "xenial xerus" does not come with Python 2.x by default. It is possible to install a python-2.7 package, but this has its own problem: no `python` or `python2` symlink (see bitcoin#7717). This fixes the following scripts to work with python 3: - `make check` (bctest,py, bitcoin-util-test.py) - `make translate` (extract_strings_qt.py) - `make symbols-check` (symbol-check.py) - `make security-check` (security-check.py) Explicitly call the python commands using $(PYTHON) instead of relying on the interpreter line at the top of the scripts.
laanwj
force-pushed
the
2016_03_build_python_3
branch
from
cb01698
to
18f05c7
Compare
|
Squashed b875273, b40e365 and cb01698 into 18f05c7 |
laanwj
added a commit
that referenced
this pull request
Mar 29, 2016
18f05c7 build: python 3 compatibility (Wladimir J. van der Laan)
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Apr 3, 2016
This fixes the gitian MacOSX build, it was broken in bitcoin#7723. The patch to `native_mac_alias` should probably make it upstream.
theuni
pushed a commit
to theuni/bitcoin
that referenced
this pull request
Apr 21, 2016
This fixes the gitian MacOSX build, it was broken in bitcoin#7723. The patch to `native_mac_alias` should probably make it upstream.
pstratem
pushed a commit
to pstratem/bitcoin
that referenced
this pull request
May 1, 2016
This fixes the gitian MacOSX build, it was broken in bitcoin#7723. The patch to `native_mac_alias` should probably make it upstream.
ChoHag
added a commit
to ChoHag/bitcoin
that referenced
this pull request
Jun 28, 2016
maflcko
pushed a commit
that referenced
this pull request
Aug 15, 2016
7b01ce2 Favour python over python2 as per PR #7723 (Matthew King) 873e81f Use portable #! in python scripts (/usr/bin/env) (Matthew King)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 19, 2017
18f05c7 build: python 3 compatibility (Wladimir J. van der Laan)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 20, 2017
This fixes the gitian MacOSX build, it was broken in bitcoin#7723. The patch to `native_mac_alias` should probably make it upstream.
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 8, 2018
…n/env) 7b01ce2 Favour python over python2 as per PR bitcoin#7723 (Matthew King) 873e81f Use portable #! in python scripts (/usr/bin/env) (Matthew King)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 12, 2018
This fixes the gitian MacOSX build, it was broken in bitcoin#7723. The patch to `native_mac_alias` should probably make it upstream.
michelvankessel
pushed a commit
to michelvankessel/blackcoin-more
that referenced
this pull request
Jan 4, 2019
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…n/env) 7b01ce2 Favour python over python2 as per PR bitcoin#7723 (Matthew King) 873e81f Use portable #! in python scripts (/usr/bin/env) (Matthew King)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
This fixes the gitian MacOSX build, it was broken in bitcoin#7723. The patch to `native_mac_alias` should probably make it upstream.
CryptoCentric
added a commit
to absolute-community/absolute
that referenced
this pull request
Feb 15, 2019
Tests: Use portable #! in python scripts (/usr/bin/env) 7b01ce2 Favour python over python2 as per PR bitcoin#7723 (Matthew King) 873e81f Use portable #! in python scripts (/usr/bin/env) (Matthew King)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 16.04 "xenial xerus" does not come with Python 2.x by default. It is possible to install a python-2.7 package, but this has its own problem: no
pythonorpython2symlink (see #7717).This fixes the following scripts to work with python 3:
make check(bctest,py, bitcoin-util-test.py)make translate(extract_strings_qt.py)make symbols-check(symbol-check.py)make security-check(security-check.py)make deployfor OS X (custom_dsstore.py, macdeployqtplus)Explicitly call the python commands using $(PYTHON) (detected by autoconf) instead of relying on the interpreter line at the top of the scripts.
Python 2.x compatibility should be unaffected. For the build system I think it's good to have both Python2 and Python3 compatibility. This is not necessary for the other python scripts, such as the RPC tests. For practical reasons it's ok to have an explicit Python 2.7 dependency for those - though we'll have to document that.