Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
build: python 3 compatibility #7723
Ubuntu 16.04 "xenial xerus" does not come with Python 2.x by default. It is possible to install a python-2.7 package, but this has its own problem: no
This fixes the following scripts to work with python 3:
Explicitly call the python commands using $(PYTHON) (detected by autoconf) instead of relying on the interpreter line at the top of the scripts.
Python 2.x compatibility should be unaffected. For the build system I think it's good to have both Python2 and Python3 compatibility. This is not necessary for the other python scripts, such as the RPC tests. For practical reasons it's ok to have an explicit Python 2.7 dependency for those - though we'll have to document that.
referenced this pull request
Mar 21, 2016
Why not use
@laanwj Aha, clever fix :)
I'm not well-versed in python2/python3 to comment on the compat there, but concept ack for sure.
Looks like some of the mac deploy scripts are missing, though:
Those both get hit via