Full-precision display and entry for JSON and GUI #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forum thread to discuss: http://www.bitcoin.org/smf/index.php?topic=3786.0 |
rdponticelli
pushed a commit
to Criptomonedas/bitcoin
that referenced
this pull request
Nov 26, 2014
ae2679b Add bench_inv tool (Pieter Wuille)
destenson
pushed a commit
to destenson/bitcoin--bitcoin
that referenced
this pull request
Jun 26, 2016
classesjack
pushed a commit
to classesjack/bitcoin
that referenced
this pull request
Jan 2, 2018
Possible to submit a block with an arbitrary hashStateRoot or hashUTXORoot (Qtum Core / issue#78)
cryptapus
added a commit
to cryptapus/bitcoin
that referenced
this pull request
Jan 12, 2018
added contributors
CryptAxe
pushed a commit
to CryptAxe/bitcoin
that referenced
this pull request
Mar 11, 2018
Add configuration info
laanwj
added a commit
that referenced
this pull request
Feb 22, 2021
67f2631 gui: Add monospaced font settings (Hennadii Stepanov) 22e0114 qt: Choose monospaced font in C++ code rather in `*.ui` file (Hennadii Stepanov) 623de12 qt: Make GUIUtil::fixedPitchFont aware of embedded font (Hennadii Stepanov) 89e4219 gui: Add Roboto Mono font (Hennadii Stepanov) Pull request description: Qt does not guarantee that the actual applied font matches to the requested one. It was noted (#16432 (comment)): > the monospace font looks a bit weird no macOS ... because it is _not_ monospaced. Also some discrepancies I've noted on Windows while testing Qt 5.15 ([#19716](#19716)). Of course, we could check the actual font with `QFontInfo`, and try to choose another font. But this PR suggests to just embed a monospaced font, and get the GUI look (partially) independent from a platform. [Roboto Mono](https://fonts.google.com/specimen/Roboto+Mono) was chosen after discussion with Bitcoin Design community, and due to its [Apache License, Version 2.0](https://fonts.google.com/specimen/Roboto+Mono#license). Changes are scoped to the Overview page only. --- Screenshots on macOS 10.15.6 (images are simulated by code patching): - master (ca30d34)  - this PR (3fdd5b6)  --- More screenshots added after bitcoin-core/gui#79 (comment): - Linux Mint 20.1 + Cinnamon DE  - Windows 10 (with depends)  - macOS Big Sur (with depends)  ACKs for top commit: laanwj: Tested ACK 67f2631 Tree-SHA512: a59775570b8ce314669ede50a0b69f53e8a47a41e7eea428835013240f0ce9afcff6e4c258895455b56806417ed877e5b7a9522f1904e95a5f435db8ccf6078c
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies FormatMoney to display full-precision values (with trailing zeroes trimmed correctly-- e.g. 0 is 0.00 but 0.00010000 displays as 0.0001).
And ParseMoney allows entry of full-precision values.
And JSON's AmountFromValue doesn't round to two places, so you can send/move full-precision values.