New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerifyDB: don't check blocks that have been pruned #8076

Merged
merged 1 commit into from May 25, 2016

Conversation

Projects
None yet
8 participants
@sdaftuar
Member

sdaftuar commented May 20, 2016

If a pruning node ends up in a state where it has very few blocks on disk, then a node could fail to start up in VerifyDB. This pull changes the behavior for pruning nodes, so that we will just not bother trying to check blocks that have been pruned.

I don't expect this edge case to be triggered much in practice currently; this is a preparatory commit for segwit (to deal with the case of pruning nodes that upgrade after segwit activation).

@sipa

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 20, 2016

Member

utACK b88515167cc2a5da7dc11f66c58404cc06c92838

Member

sipa commented May 20, 2016

utACK b88515167cc2a5da7dc11f66c58404cc06c92838

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 20, 2016

Member

utACK b885151

Member

MarcoFalke commented May 20, 2016

utACK b885151

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell May 20, 2016

Member

utACK b88515167cc2a5da7dc11f66c58404cc06c92838 but this could also log when it runs out of data (might avoid a future bug where it hits that branch immediately and ends up checking nothing).

Member

gmaxwell commented May 20, 2016

utACK b88515167cc2a5da7dc11f66c58404cc06c92838 but this could also log when it runs out of data (might avoid a future bug where it hits that branch immediately and ends up checking nothing).

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli May 20, 2016

Member

utACK b88515167cc2a5da7dc11f66c58404cc06c92838

Member

jonasschnelli commented May 20, 2016

utACK b88515167cc2a5da7dc11f66c58404cc06c92838

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 21, 2016

Member

utACK b885151

Member

fanquake commented May 21, 2016

utACK b885151

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar May 22, 2016

Member

Added logging for when it runs out of data, as @gmaxwell suggested.

Member

sdaftuar commented May 22, 2016

Added logging for when it runs out of data, as @gmaxwell suggested.

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens May 23, 2016

Contributor

utACK bd477f4

Contributor

dcousens commented May 23, 2016

utACK bd477f4

@sipa sipa merged commit bd477f4 into bitcoin:master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request May 25, 2016

Merge #8076: VerifyDB: don't check blocks that have been pruned
bd477f4 VerifyDB: don't check blocks that have been pruned (Suhas Daftuar)

sickpig referenced this pull request in sickpig/BitcoinUnlimited Feb 17, 2017

Merge #8076: VerifyDB: don't check blocks that have been pruned
bd477f4 VerifyDB: don't check blocks that have been pruned (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge bitcoin#8076: VerifyDB: don't check blocks that have been pruned
bd477f4 VerifyDB: don't check blocks that have been pruned (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#8076: VerifyDB: don't check blocks that have been pruned
bd477f4 VerifyDB: don't check blocks that have been pruned (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge bitcoin#8076: VerifyDB: don't check blocks that have been pruned
bd477f4 VerifyDB: don't check blocks that have been pruned (Suhas Daftuar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment