VerifyDB: don't check blocks that have been pruned #8076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK b88515167cc2a5da7dc11f66c58404cc06c92838 |
|
utACK b885151 |
|
utACK b88515167cc2a5da7dc11f66c58404cc06c92838 but this could also log when it runs out of data (might avoid a future bug where it hits that branch immediately and ends up checking nothing). |
|
utACK b88515167cc2a5da7dc11f66c58404cc06c92838 |
|
utACK b885151 |
sdaftuar
force-pushed
the
pruning-checkblocks
branch
from
b885151
to
bd477f4
Compare
|
Added logging for when it runs out of data, as @gmaxwell suggested. |
|
utACK bd477f4 |
sipa
added a commit
that referenced
this pull request
May 25, 2016
bd477f4 VerifyDB: don't check blocks that have been pruned (Suhas Daftuar)
sickpig
referenced
this pull request
in sickpig/BitcoinUnlimited
Feb 17, 2017
bd477f4 VerifyDB: don't check blocks that have been pruned (Suhas Daftuar)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 21, 2017
bd477f4 VerifyDB: don't check blocks that have been pruned (Suhas Daftuar)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pruning node ends up in a state where it has very few blocks on disk, then a node could fail to start up in
VerifyDB. This pull changes the behavior for pruning nodes, so that we will just not bother trying to check blocks that have been pruned.I don't expect this edge case to be triggered much in practice currently; this is a preparatory commit for segwit (to deal with the case of pruning nodes that upgrade after segwit activation).
@sipa