New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Remove client name from debug window #8281

Merged
merged 1 commit into from Jun 29, 2016

Conversation

Projects
None yet
6 participants
@laanwj
Member

laanwj commented Jun 28, 2016

Remove the client name from the debug window in the GUI:

  • It is a constant, there is no way to change it anyway (apart from editing the code)
  • It is already part of the user agent, so mentioning it in a separate row doesn't add anything

Before:

untitled1

After:

untitled2

qt: Remove client name from debug window
Remove the client name from the debug window in the GUI. It is already
part of the user agent, so adding it separately doesn't add anything.

@laanwj laanwj added the GUI label Jun 28, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 28, 2016

Member

Concept ACK

Member

MarcoFalke commented Jun 28, 2016

Concept ACK

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 28, 2016

Contributor

ACK a7897c0

Contributor

paveljanik commented Jun 28, 2016

ACK a7897c0

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 28, 2016

Member

Good idea.
utACK a7897c0

Member

jonasschnelli commented Jun 28, 2016

Good idea.
utACK a7897c0

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jun 29, 2016

Member

ACK

On Wednesday, 29 June 2016, Jonas Schnelli notifications@github.com wrote:

Good idea.
utACK a7897c0
a7897c0


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8281 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA0t8g7OTePGtG1ZW6kJt-zuJ9LfDfTxks5qQYDPgaJpZM4JASlx
.

Member

fanquake commented Jun 29, 2016

ACK

On Wednesday, 29 June 2016, Jonas Schnelli notifications@github.com wrote:

Good idea.
utACK a7897c0
a7897c0


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8281 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA0t8g7OTePGtG1ZW6kJt-zuJ9LfDfTxks5qQYDPgaJpZM4JASlx
.

@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd Jun 29, 2016

Contributor

Concept ACK

Contributor

petertodd commented Jun 29, 2016

Concept ACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 29, 2016

Member

Tested ACK a7897c0

Member

jonasschnelli commented Jun 29, 2016

Tested ACK a7897c0

@jonasschnelli jonasschnelli merged commit a7897c0 into bitcoin:master Jun 29, 2016

jonasschnelli added a commit that referenced this pull request Jun 29, 2016

Merge #8281: qt: Remove client name from debug window
a7897c0 qt: Remove client name from debug window (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8281: qt: Remove client name from debug window
a7897c0 qt: Remove client name from debug window (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8281: qt: Remove client name from debug window
a7897c0 qt: Remove client name from debug window (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8281: qt: Remove client name from debug window
a7897c0 qt: Remove client name from debug window (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment