Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt: Remove client name from debug window #8281

Merged
merged 1 commit into from
Jun 29, 2016
Merged

qt: Remove client name from debug window #8281

merged 1 commit into from
Jun 29, 2016

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Jun 28, 2016 •
edited
Loading

Remove the client name from the debug window in the GUI:

  • It is a constant, there is no way to change it anyway (apart from editing the code)
  • It is already part of the user agent, so mentioning it in a separate row doesn't add anything

Before:

untitled1

After:

untitled2

@laanwj
qt: Remove client name from debug window
a7897c0 
Remove the client name from the debug window in the GUI. It is already
part of the user agent, so adding it separately doesn't add anything.
@laanwj laanwj added the GUI label Jun 28, 2016
@maflcko
Copy link
Member

maflcko commented Jun 28, 2016

Concept ACK

@paveljanik
Copy link
Contributor

ACK a7897c0

@jonasschnelli
Copy link
Contributor

Good idea.
utACK a7897c0

@fanquake
Copy link
Member

ACK

On Wednesday, 29 June 2016, Jonas Schnelli notifications@github.com wrote:

Good idea.
utACK a7897c0
a7897c0

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8281 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA0t8g7OTePGtG1ZW6kJt-zuJ9LfDfTxks5qQYDPgaJpZM4JASlx
.

@petertodd
Copy link
Contributor

Concept ACK

@jonasschnelli
Copy link
Contributor

Tested ACK a7897c0

@jonasschnelli jonasschnelli merged commit a7897c0 into bitcoin:master Jun 29, 2016
jonasschnelli added a commit that referenced this pull request Jun 29, 2016
@jonasschnelli
Merge #8281: qt: Remove client name from debug window
6a87eb0 
a7897c0 qt: Remove client name from debug window (Wladimir J. van der Laan)
codablock pushed a commit to codablock/dash that referenced this pull request Dec 28, 2017
@jonasschnelli @codablock
Merge bitcoin#8281: qt: Remove client name from debug window
ba6b369 
a7897c0 qt: Remove client name from debug window (Wladimir J. van der Laan)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@jonasschnelli @andvgal
Merge bitcoin#8281: qt: Remove client name from debug window
89bace8 
a7897c0 qt: Remove client name from debug window (Wladimir J. van der Laan)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@laanwj @maflcko @paveljanik @jonasschnelli @fanquake @petertodd