Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AdvertiseLocal debug output to net category #8283

Closed
wants to merge 4 commits into from
Closed

Move AdvertiseLocal debug output to net category #8283

wants to merge 4 commits into from

Conversation

Mirobit
Copy link
Contributor

@Mirobit Mirobit commented Jun 28, 2016

Not sure why this information is needed in the gernal debug log.

Not sure why this information is needed in the gernal debug log.
@maflcko maflcko added the Docs label Jun 29, 2016
@fanquake
Copy link
Member

Please squash your commits.

@laanwj
Copy link
Member

laanwj commented Jun 29, 2016

Yes, why not, Concept ACK
See here for commit squashing instructions: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

@paveljanik
Copy link
Contributor

Concept ACK

@laanwj
Copy link
Member

laanwj commented Jul 11, 2016

That didn't work, now you have added two commits including a merge commit.

@maflcko
Copy link
Member

maflcko commented Jul 11, 2016

You can try

git reset f4a59ab~
git commit -m "Move AdvertiseLocal debug output to net category" src/ 

@laanwj
Copy link
Member

laanwj commented Aug 4, 2016

Still needs squashing.
If you really don't manage to do so (try to follow @MarcoFalke's steps), you could re-do the changes as one commit.

@Mirobit Mirobit closed this Aug 5, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants