libconsensus: Expose a flag for BIP112 #8412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why arent you following the status quo for naming? |
|
I'm saying it, I thought adding bip112 at the end would be more useful, changing back already... |
We added the segwit one, but we forgot CHECKSEQUENCEVERIFY
jtimon
force-pushed
the
0.13-consensus-bip112-flag
branch
from
789fd70
to
d12b732
Compare
|
Updated following the style and without adding BIP112 at the end. |
|
ACK d12b732 |
|
utACK d12b732 |
|
utACK d12b732 |
1 similar comment
|
utACK d12b732 |
sipa
added a commit
that referenced
this pull request
Jul 28, 2016
d12b732 libconsensus: Expose a flag for BIP112 (Jorge Timón)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 8, 2018
d12b732 libconsensus: Expose a flag for BIP112 (Jorge Timón)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
d12b732 libconsensus: Expose a flag for BIP112 (Jorge Timón)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the segwit one, but we forgot CHECKSEQUENCEVERIFY.
@laanwj this needs backport to 0.13, right?
In fact, I'm thinking that this should have been included in 0.12.1...
Ping @sipa @TheBlueMatt
Bikeshedding: I removed "FLAGS_" in this one and added "_BIP112" at the end instead because I believe it's more useful. I'm happy to change the name of the flag.EDIT: Note that the bit positions have to correspond with those in the flags for scripts in script/interpreter.h.