Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: little typos #8537

Closed
wants to merge 1 commit into from
Closed

Trivial: little typos #8537

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2016

I wish I could merge it with #8505

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Aug 18, 2016

Trivial ACK b6190a7.
It's good to have only a few of these typo fix PRs and combine them as much as possible to not disturb other PRs.

@sipa
Copy link
Member

sipa commented Aug 18, 2016 via email

@jonasschnelli
Copy link
Contributor

Oh. Right. Change is on a subtree.
un-Trivial-ACK.

@ghost
Copy link
Author

ghost commented Aug 18, 2016

It's good to have only a few of these typo fix PRs and combine them as much as possible to not disturb other PRs.

Yes, 2 typos for a Pull Request isn't enough.

I'll close this Pull Request because...

Please don't change code inside the leveldb subtree directly. You could do
so through the https://github.com/bitcoin/leveldb repository (which is
sometimes synced with the src/leveldb directory), however.

...because I'll open A Pull Request in leveldb repo.

@ghost ghost closed this Aug 18, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants