There's two types of flags: consensus and script #9271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
from
5a72152
to
950616a
Compare
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
2 times, most recently
from
c3c7ff6
to
7a90173
Compare
reinier19
approved these changes
Dec 4, 2016
reinier19
approved these changes
Dec 4, 2016
|
good |
|
hajs |
reinier1991
approved these changes
Dec 4, 2016
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
3 times, most recently
from
12bd793
to
711d92a
Compare
jtimon
changed the title
|
Updated code and description. EDIT: sorry! still failing tests for a supposedly simple POC! Also sorry for maybe making more commits than necessary, squash suggestions very wecomed, specially if they contain suggestions about the new commit message. |
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
8 times, most recently
from
9b1a273
to
a813b0a
Compare
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
from
cc44a6f
to
e12cd59
Compare
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
from
e12cd59
to
1c0a3d9
Compare
|
Rebased, still don't understand why the script_tests.cpp are failing. |
jtimon
changed the title
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
from
1c0a3d9
to
f2fc1c6
Compare
|
Needed rebase, rebased on top of #10427 |
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
from
f2fc1c6
to
b6a84fc
Compare
|
Needed rebase, even though the first commit of #10192 hasn't been merged yet (that will need rebase too). |
...to make sure only consensus flags as an interface to bitcoinconsensus TODO: Decouple the bits in consensus flags from the ones in the interpreter flags
this also helps test ScriptFlagsFromConsensus
- Replacing GetBlockScriptFlags - Use GetConsensusFlags and ScriptFlagsFromConsensus from ConnectBlock and LimitMempoolSize
...and use it from GetConsensusFlags() Nothing can be deployed the block after genesis (ie BIP30: Don't look for ancestors of the genesis block)
jtimon
force-pushed
the
0.13-consensus-flags-error
branch
from
b6a84fc
to
6bd6a57
Compare
|
Closing for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #7779
Unlike the previous, this distinguishes between consensus flags and the subset of them that are only related to script. We can decouple them from each other.
There's extra exploration in https://github.com/jtimon/bitcoin/commits/0.13-consensus-flags
Things to explore:
Calling GetConsensusFlags from ContextualCheckBlock or "upwards" should look bad in benchmarks (although maybe not so much since bip9 is cached and ISM has been eliminated), but would complete GetConsensusFlags().
Moving GetConsensusFlags "upwards" can reduce the impact of unifying logic from both ConnectBlock and ContextualCheckBlock in GetConsensusFlags.