-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readability of segwit.py, smartfees.py #9970
Merged
laanwj
merged 2 commits into
bitcoin:master
from
sdaftuar:2017-03-segwit-test-improvements
Mar 14, 2017
Merged
Improve readability of segwit.py, smartfees.py #9970
laanwj
merged 2 commits into
bitcoin:master
from
sdaftuar:2017-03-segwit-test-improvements
Mar 14, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdaftuar
force-pushed
the
2017-03-segwit-test-improvements
branch
from
March 10, 2017 16:41
21b76b5
to
fede1cb
Compare
Force-pushed with a fix to |
sdaftuar
changed the title
Improve readability of segwit.py
Improve readability of segwit.py, smartfees.py
Mar 10, 2017
sdaftuar
force-pushed
the
2017-03-segwit-test-improvements
branch
from
March 11, 2017 02:13
bc9a01a
to
1269b8a
Compare
Rebased after #9768 |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 21, 2019
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 29, 2019
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 26, 2019
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 26, 2019
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work is surely needed, but I tried to clean up some hard-to-understand helper functions.
Also fixed a logging bug in
smartfees.py
(introduced in #9768).