This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Build JVM bdk-ffi libs for macos m1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
build_macos_m1
branch
from
c6d721d
to
7b060f2
Compare
|
Once this is done, check off list in bitcoindevkit/bdk-ffi#76 |
9 tasks
thunderbiscuit
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
The publishing worked on my machine. One little thing: the ./gradlew test command failed because of a mismatch of APIs I think (the new API only has a Wallet so I think the tests would need to be slightly adjusted).
I can work on that in a separate small PR if you'd like to merge this; it's otherwise good to go.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bdk-ffi