You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a branch-out issue from both #1448 and #1468, as suggested this issue is specifically meant for trying to reproduce the expected panic! (insatiable descriptor), and fix the .unwrap() usage with appropriate approach.
Use case
Clarifies if the expected panic! ever happens, or it's a totally unexpected situation.
Additional context
The text was updated successfully, but these errors were encountered:
438cd46 refactor(wallet)!: change WeightedUtxo to use Weight type (Leonardo Lima)
Pull request description:
fixes#1466
depends on #1448
<!-- You can erase any parts of this template not applicable to your Pull Request. -->
### Description
This PR is a follow-up on top of #1448, and should be rebased and merged after it, it uses the rust-bitcoin `Weight` type instead of the current `usize` usage.
NOTE: ~~It also adds a new `MiniscriptError` variant, and remove the `.unwrap()` usage.~~ As suggested I'll address this on another issue #1485, trying to reproduce the error first.
<!-- Describe the purpose of this PR, what's being adding and/or fixed -->
### Notes to the reviewers
It should be ready to review after #1448 gets merged.
<!-- In this section you can include notes directed to the reviewers, like explaining why some parts
of the PR were done in a specific way -->
### Changelog notice
- Change `WeightedUtxo` `satisfaction_weight` has been changed to use `Weight` type.
- Change `TxBuilder` methods `add_foreign_utxo` and `add_foreign_utxo_with_sequence` to expect `Weight` as `satisfaction_weight` type.
<!-- Notice the release manager should include in the release tag message changelog -->
<!-- See https://keepachangelog.com/en/1.0.0/ for examples -->
### Checklists
#### All Submissions:
* [x] I've signed all my commits
* [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
* [x] I ran `cargo fmt` and `cargo clippy` before committing
ACKs for top commit:
storopoli:
Anyways, ACK 438cd46
notmandatory:
ACK 438cd46
Tree-SHA512: 1998fe659833da890ce07aa746572ae24d035e636732c1a11b7828ffed48e753adb4108f42d00b7cd05e6f45831a7a9840faa26f94058fc13760497837af002f
Describe the enhancement
It's a branch-out issue from both #1448 and #1468, as suggested this issue is specifically meant for trying to reproduce the expected panic! (insatiable descriptor), and fix the
.unwrap()
usage with appropriate approach.Use case
Clarifies if the expected panic! ever happens, or it's a totally unexpected situation.
Additional context
The text was updated successfully, but these errors were encountered: