Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fee sniping deterrence [BIP326] #1251

Closed
wants to merge 3 commits into from
Closed

Improve fee sniping deterrence [BIP326] #1251

wants to merge 3 commits into from

Commits on Dec 28, 2023

  1. feat(wallet): bip326 anti-fee sniping

    @ValuedMammal
    ValuedMammal committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    0733d7a View commit details
    Browse the repository at this point in the history

  2. test(wallet): test anti fee sniping logic 

    This change adds two tests to wallet.rs. In
`test_create_tx_fee_sniping_tr` we check that for a taproot
transaction with rbf enabled, either the tx LockTime is set to the most
recent checkpoint, or the input's Sequence is set to its confirmations
(allowing for randomness in both cases).

In `test_create_tx_fee_sniping_tr_csv` we check that policy
csv requirements take precedence over a default nSequence. A new
test descriptor getter is added to common.rs
`get_test_tr_with_taptree_csv` that contains a script path with a csv
condition.
    @ValuedMammal
    ValuedMammal committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1c2ec03 View commit details
    Browse the repository at this point in the history

  3. test(wallet): remove duplicate test for default locktime

    @ValuedMammal
    ValuedMammal committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    19ea047 View commit details
    Browse the repository at this point in the history