fix(file_store): rm lifetime from FileError
#1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
force-pushed
the
file_store_rm_error_lifetime
branch
from
b7e216f
to
976b707
Compare
The lifetime on the error needed to be the same as the input magic bytes which was annoying.
evanlinjin
force-pushed
the
file_store_rm_error_lifetime
branch
from
976b707
to
5611c9e
Compare
LLFourn
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The lifetime on the error needed to be the same as the input magic bytes which was annoying.
Changelog notice
Fixed
bdk_file_store::FileErrorlifetime.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing