-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TxBuilder allow_shrinking() and unneeded context param #1386
Remove TxBuilder allow_shrinking() and unneeded context param #1386
Conversation
7abec98
to
b51fa22
Compare
@LLFourn I did a little more than just remove TxBuilder::allow_shrinking in this PR. If you think it's too much to remove the TxBuilder context I can put it back in, but then I'll need to either remove the two tests I updated or add the functions I needed to work for either context. |
25a81fa
to
4073c43
Compare
LGTM Conceptually, I think |
e35839a
to
1ab9204
Compare
ACK 1ab9204 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1ab9204
f3dcb60
to
97e2508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 97e2508
ACK 97e2508 |
97e2508
to
096b8ef
Compare
Description
Remove wallet::TxBuilder::allow_shrinking() and unneeded TxBuilder context param.
Fixes #1374
Notes to the reviewers
The allow_shrinking function was the only one using the TxBuilder FeeBump context and it's useful to have CreateTx context functions available for building FeeBump transactions, see updated tests.
Changelog notice
Changed
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingBugfixes: