fix(wallet)!: Simplify SignOptions
and improve finalization logic
#1476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than comingle various
SignOptions
with the finalization step, we simply clear all fields when finalizing as per the PSBT spec in BIPs 174 and 371 which is more in line with user expectations.Notes to the reviewers
I chose to re-implement some parts of
finalize_input
since it's fairly straightforward, see also #1461 (comment). I had to refactor some wallet tests but didn't go out of my way to add additional tests.closes #1461
Changelog notice
remove_partial_sigs
fromSignOptions
remove_taproot_extras
fromSignOptions
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingBugfixes: