-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(chain)!: Update KeychainTxOutIndex methods to use owned K and ScriptBuf #1506
Conversation
I pushed commit to also update |
⛏️ @rustaceanrob one small thing, can you change your commit description to be a little more descriptive, something like:
|
KeychainTxOutIndex
I added a commit to limit tests to 2 threads, this is what I've always had to do locally to fix an issue with |
Oh the nasty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ade5999
This needs to be rebased after #1514 is merged. |
e239dcf
to
515f252
Compare
I pushed a test rebase, will do final rebase after #1514 is merged. |
KeychainTxOutIndex
KeychainTxOutIndex
methods to use owned K and ScriptBuf
KeychainTxOutIndex
methods to use owned K and ScriptBuf
Description
Make all method signatures of
KeychainTxOutIndex
take ownedK
and useScriptBuf
instead of its borrowed counterpart&Script
. Fixes #1482Notes to the reviewers
Steve also added a CI fix as well
Changelog notice
KeychainTxOutIndex
take ownedK
KeychainTxOutIndex
methods to useScriptBuf
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: