refactor(chain)! SyncRequest ergonomics improvements #1528
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to improve the ergonomics of sync request especially with regards to inspecting the progress of the sync.
Now there is a single
inspect
method which takes a closure which gets richer information than the previous ones. It takes:where the
usize
s are the index of the current item and the number of items remaining respectively.SyncItem
is defined as:Note carefully the type parameter
I
inside which is just to help log out the index (or whatever metadata you want) along with the spk.This is not ready for review but I thought @evanlinjin might be interested in finishing this work.