Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Generate a different cache key for every job #181

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

afilini
Copy link
Member

@afilini afilini commented Nov 19, 2020

Without this fix every job was using essentially the same cache key, which meant that they were all using the cache uploaded by the first runner to finish whenever we made some changes to Cargo.toml.

This fix should in theory yield a nice performance boost, especially on jobs that are particularly slow, like when compact_filters is enabled.

If this works out, we can close #157 because after the first run the compiled librocksdb-sys should stay cached for all the subsequent ones.

@RCasatta
Copy link
Member

ack 0edcc83

@afilini afilini merged commit 0edcc83 into bitcoindevkit:master Nov 19, 2020
@afilini afilini deleted the fix/ci-cache-keys branch November 20, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try installing librocksdb to make the CI faster with compact_filters enabled
3 participants