Make Esplora feature optional for CLI/REPL

[eupn]

I found this low-hanging fruit in Discord about making esplora optional for CLI.

[afilini]

Concept ACK, though I would return an error if an esplora server is specified while the feature is disabled. Something that tells the user to enable the feature first

[eupn]

It shouldn’t be possible to specify Esplora settings if the feature is not enabled. Clap/StructOpt will return an error that it doesn’t know about this parameter since it was excluded from the code.

…

https://github.com/notifications/unsubscribe-auth/AIU4QVD4OK4D7YZ25FOZYSLST5O4PANCNFSM4UTH4ULQ

[notmandatory]

ACK 5b34f0d
@eupn are you able to sign your commits?

I tested repl with and without the esplora features. I can confirm that if the esplora feature is not used then esplora options return an appropriate error, ie:

$ cargo run --features cli-utils --example repl -- --descriptor "wpkh(tpubEBr4i6yk5nf5DAaJpsi9N2pPYBeJ7fZ5Z9rmN4977iYLCGco1VyjB9tvvuvYtfZzjD5A8igzgw3HeWeeKFmanHYqksqZXYXGsw5zjnj7KM9/*)" --esplora_concurrency 2 sync

error: Found argument '--esplora_concurrency' which wasn't expected, or isn't valid in this context

[eupn]

@notmandatory, let me set up signing tools. I'll force-push signed commits.

[eupn]

@notmandatory commits are signed.

[afilini]

I think you've only signed the last two commits, not all three. Sorry to bother you again with this.. :(

[eupn]

@afilini no worries, my bad!

[afilini]

ACK c9a05c0, thanks!