Add the pull request template #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afilini
force-pushed
the
feat/pull-request-template
branch
2 times, most recently
from
033bf6d
to
978095f
Compare
.github/pull_request_template.md
Outdated
|
|
||
| ### Description | ||
|
|
||
| <!-- Describe the purpose of this PR, what being adding and/or fixed --> |
There was a problem hiding this comment.
small typo, should read ... what is being added ...
.github/pull_request_template.md
Outdated
| #### Bugfixes: | ||
|
|
||
| * [] This pull request breaks the existing API | ||
| * [] I've added a test to reproduce the issue which are now passing |
There was a problem hiding this comment.
small thing, to make plural agree.. I've added tests to reproduce the issue which are now passing
|
Overall great idea, I just have some small English suggestions |
afilini
force-pushed
the
feat/pull-request-template
branch
from
978095f
to
6c768e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the template for pull requests, which contains a few checklists that contributors can use to make sure they've done everything right before submitting their patches.
Checklists
All Submissions: