bugfix: keep BTreeMap for SignersContainer #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afilini
reviewed
Dec 15, 2020
afilini
approved these changes
Dec 16, 2020
nickfarrow
pushed a commit
to nickfarrow/bdk
that referenced
this pull request
Feb 21, 2022
Satisfaction bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #224 when we decided that while the main cause of bug is fixed, it's better to try to keep the
BTreeMapas a primary data structure for the container.This PR reverts some commits from the previous one, but keeps the unit tests and adds fix to the
findfunction.Notes to the reviewers
The fix to the
findfunction introduced in commit c58236f may not be the best one. Is there a better way?Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes:
SignersContainer::findfunction)