-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MemoryDatabase Send + Sync #448
Make MemoryDatabase Send + Sync #448
Conversation
c0af613
to
b1beaf6
Compare
This LGTM. I think the idea here is to make sure that if you No idea why these resolver test failures are reappearing in our CI. |
I'm not sure I understand the |
Is this something to be fixed by me? |
Nah we should fix this. |
The issue should be fixed now, you can try rebasing on the latest |
b1beaf6
to
7d5891b
Compare
7d5891b
to
59f795f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 59f795f.
Description
We make the
MemoryDatabase
Send + Sync
. This is required for language bindings generation using uniffi-rs and is a very small change.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing