Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement XKeyUtils on InnerXKey #542

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Implement XKeyUtils on InnerXKey #542

merged 1 commit into from
Feb 14, 2022

Conversation

acerbisgianluca
Copy link
Contributor

@acerbisgianluca acerbisgianluca commented Feb 12, 2022 •
edited
Loading

Closes #395

Description

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@acerbisgianluca acerbisgianluca marked this pull request as ready for review February 12, 2022 15:38
@danielabrozzoni
Copy link
Member

ACK b6fe01c - the code looks good to me, I tested locally and all tests pass

notmandatory
notmandatory approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b6fe01c

Thanks!

@afilini afilini merged commit 0efbece into bitcoindevkit:master Feb 14, 2022
@acerbisgianluca acerbisgianluca deleted the fix/use-innerxkey branch February 15, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BDK Maintenance
Archived in project
Milestone
Release 0.17.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.

InnerXKey is public
4 participants
@acerbisgianluca @danielabrozzoni @notmandatory @afilini