Fix wallet export rescan height #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would return the latest transaction height rather than the earliest :S
|
The Changelog notice section is where you'd put what ever change log message (if any) you want put in the release notes changelog (which we now manually put together and add to the release tag and on Github releases page). |
24 tasks
19 tasks
rajarshimaitra
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
tACK e9bbb87
Yup makes sense to export the "sync from" height rather than last seen height..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would return the latest transaction height rather than the earliest as the height to rescan from.
Found by @evanlinjin and I while implementing
bdk_corestuff into bdk's wallet.Changelog notice
All Submissions: