Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm compatible database using gloo_storage::LocalStorage #789

Closed
wants to merge 1 commit into from

Conversation

benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Oct 27, 2022

Description

Closes #450

Adds a new database type for wasm builds. This is basically copied from MutinyWallet/mutiny-node#5

Notes to the reviewers

I am not sure if the tests are working correctly, couldnt figure out how to properly run with them without wasm-pack

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@notmandatory
Copy link
Member

@futurepaul sorry for the delay in commenting on this PR, it looks like a great addition but right now we're trying to avoid adding new features like this to bdk until we know how it will fit in with the bdk_core release 1.0 refactoring that the team is focused on. Rather than wait for that to shake out, since you're only implementing a bdk public trait how would you feel about making a little repo for this in your account? That way anyone who wants to try it out can easily add it as a dependency and you'll be able to iterate quickly on improvements. Then in a few months once the new bdk 1.0 APIs are solidified we can revisit pulling this into the bitcoindevkit org.

@benthecarman benthecarman deleted the gloo-db branch May 2, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Wasm compatible Database for bdk
2 participants