Skip to content

Add weight and ability to get strippedsize #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2019
Merged

Add weight and ability to get strippedsize #1515

merged 2 commits into from
Dec 9, 2019

Conversation

junderw
Copy link
Member

@junderw junderw commented Nov 29, 2019

The issue #1509 brought to light that we had no method to get the weight of a Block.

Some questions to ponder:

  1. Using Transaction private method is bad.
  2. Maybe we should also create a private __byteLength in Block too?
  3. Should we (and if so, how?) add examples about gathering info about blocks using our Block class? (The integration test only has one example, and it's not too useful.)

d-yokoi
d-yokoi reviewed Dec 9, 2019
View reviewed changes
@d-yokoi d-yokoi merged commit 456ba5a into master Dec 9, 2019
@d-yokoi d-yokoi deleted the addWeightBlock branch December 9, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-yokoi d-yokoi d-yokoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junderw @d-yokoi