Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: add #37 (2019-03-12) #118

Merged
merged 1 commit into from Mar 12, 2019

Conversation

@harding
Copy link
Contributor

@harding harding commented Mar 12, 2019

Todo:

  • Add image

(So sorry this is so late!)

where it could be verified reasonably quickly.

O'Connor also raised a [similar concern][roconnor sighash] regarding
the soft fork's proposal to remove unallocated sighash type bytes.
Copy link
Contributor

@moneyball moneyball Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to say "treat unallocated sighash type bytes as invalid"? (vs. removing bytes)

@moneyball
Copy link
Contributor

@moneyball moneyball commented Mar 12, 2019

tACK. Other than my minor comment (which is optional to address) this newsletter looks ready to go! Oh, and the fixme image.

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Sorry for the last minute review

tack

---
title: 'Bitcoin Optech Newsletter #37'
permalink: /en/newsletters/2019/03/12/
name: 2019-03-05-newsletter
Copy link
Contributor

@bitschmidty bitschmidty Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong name

highly encouraged to [test it][0.18.0] for regressions and other
problems that could affect your use of it in production. Any testing
is appreciated, but if you have some extra time after testing for your
specific use cases, please consider helping test the GUI. This
Copy link
Contributor

@bitschmidty bitschmidty Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider helping test the GUI

Perhaps it would be useful to work in a link to all of the GUI tagged PRs in 0.18.0, to help direct people of what to test?

https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Apr+label%3AGUI+milestone%3A0.18.0

Copy link
Contributor Author

@harding harding Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a great idea, thanks!

the block header---one where it points to a single invalid 64-byte
transaction and one where it points to two valid transactions.

FIXME: image
Copy link
Contributor

@bitschmidty bitschmidty Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on your todo, just making extra sure by commenting on it.

@harding harding force-pushed the 2019-03-12-newsletter branch from 17d7e5d to 7893e88 Mar 12, 2019
@harding harding force-pushed the 2019-03-12-newsletter branch from 7893e88 to 4141ea2 Mar 12, 2019
@harding
Copy link
Contributor Author

@harding harding commented Mar 12, 2019

Addressed review comments (thanks!) and added deferred image.

@moneyball
Copy link
Contributor

@moneyball moneyball commented Mar 12, 2019

re-tested ACK

@moneyball moneyball merged commit 7b74933 into bitcoinops:master Mar 12, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants