Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: add #43 (2019-04-23) #137

Merged
merged 1 commit into from Apr 23, 2019

Conversation

@harding
Copy link
Contributor

@harding harding commented Apr 22, 2019

Notes:

  • Makes a one-word edit to a previous newsletter after I couldn't find text I knew I'd written by the keyword I was expecting. (If anyone objects, I'm 100% ok reverting that change.)
  • The BIP158 bullet is in the News section because, when I started writing it, I didn't think we had any other news. However, I remembered the LND release, which is actual news. If anyone would like, I'm happy to move the BIP158 bullet to the notable code changes section that might be more appropriate.
  • I won't be available for edits Monday afternoon/evening, so please feel free to make any edits y'all think are appropriate. (Remember the editors razor: if in doubt, delete.) I will be available early Tuesday morning, so please feel free to leave me things to fix or review then.
@jnewbery
Copy link
Contributor

@jnewbery jnewbery commented Apr 22, 2019

utACK c13a683. No review comments!

Makes a one-word edit to a previous newsletter after I couldn't find text I knew I'd written by the keyword I was expecting.

Change looks good to me 👍

The BIP158 bullet is in the News section because, when I started writing it, I didn't think we had any other news. However, I remembered the LND release, which is actual news. If anyone would like, I'm happy to move the BIP158 bullet to the notable code changes section that might be more appropriate.

No, I think this is interesting enough to be in the News section

@moneyball
Copy link
Contributor

@moneyball moneyball commented Apr 22, 2019

BIP157 not BIP158, right?

@harding harding force-pushed the 2019-04-23-newsletter branch from c13a683 to 636a4cd Apr 23, 2019
@harding
Copy link
Contributor Author

@harding harding commented Apr 23, 2019

Force-pushed a small edit to the main text and a detailed footnote explaining the differences between 157, 158, and how the current PR implements parts of both of them (but mainly 158 IMO).

@jnewbery
Copy link
Contributor

@jnewbery jnewbery commented Apr 23, 2019

Made some minor edits to the footnote: 2f070d7

@jnewbery jnewbery force-pushed the 2019-04-23-newsletter branch from 2f070d7 to aa673cc Apr 23, 2019
@jnewbery
Copy link
Contributor

@jnewbery jnewbery commented Apr 23, 2019

Squashed to aa673cc

@jnewbery jnewbery force-pushed the 2019-04-23-newsletter branch from aa673cc to a604096 Apr 23, 2019
@jnewbery jnewbery merged commit 2bd60fc into bitcoinops:master Apr 23, 2019
2 checks passed
@harding
Copy link
Contributor Author

@harding harding commented Apr 23, 2019

Post-merge ACK on the edits. Thanks, and thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants