Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: add 68 (2019-10-16) #237

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@harding
Copy link
Contributor

harding commented Oct 14, 2019

  • Check for updated RCs
  • Check for YouTube videos made public
Copy link
Contributor

jnewbery left a comment

Looks good. Just a couple of nits.

I've asked Neha and Wassim if they can provide us with the links to the DCI cryptoeconomics summit videos.

_posts/en/newsletters/2019-10-16-newsletter.md Outdated Show resolved Hide resolved
- [Bitcoin Core #17056][] adds a `sortedmulti` [output script
descriptor][] that sorts the pubkeys provided to it using the
lexicographic order described in [BIP67][]. This makes it possible to
use import xpub-based descriptors for wallets that require using BIP67,

This comment has been minimized.

Copy link
@jnewbery

jnewbery Oct 14, 2019

Contributor

s/makes it possible to use import/makes it possible to import/

@jnewbery

This comment has been minimized.

Copy link
Contributor

jnewbery commented Oct 15, 2019

ACK ea04b57

Just need to check latest RCs before merge.

@jnewbery

This comment has been minimized.

Copy link
Contributor

jnewbery commented Oct 15, 2019

Does the newsletter summary also need to be changed now that LND is a release, rather than a release candidate? It currently reads:

This week's newsletter requests testing of several release candidates, relays an update on the taproot proposal, describes a proposed increase...

Perhaps change to:

This week's newsletter announces the newest release of LND, requests testing of release candidates for Bitcoin Core and C-Lightning, relays an update on the taproot proposal, describes a proposed increase...

@moneyball

This comment has been minimized.

Copy link
Contributor

moneyball commented Oct 16, 2019

ACK

@bitschmidty bitschmidty force-pushed the harding:2019-10-16-newsletter branch from 88812d6 to 0257fc0 Oct 16, 2019
@bitschmidty

This comment has been minimized.

Copy link
Contributor

bitschmidty commented Oct 16, 2019

ACK
(pushed a small casing change to Coldcard and squashed)

Apologies for the late review!

@bitschmidty bitschmidty merged commit 24bb730 into bitcoinops:master Oct 16, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/bitcoinops/deploy-preview Deploy preview ready!
Details
@bitschmidty

This comment has been minimized.

Copy link
Contributor

bitschmidty commented Oct 16, 2019

Software from LND, C-Lightning, and Eclair
Enough to make @harding lose his hair!

Please make sure nothings out of whack
Review the taproot BIPs and provide feedback

Everything is broken, lots couldve gone wrong
Despite all of that, Bitcoins still going strong

As always, TY to @harding for authoring and the last minute updates and to @jnewbery @adamjonas and @moneyball for the reviews and feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.