Skip to content

Newsletters: add 68 (2019-10-16)#237

Merged
bitschmidty merged 1 commit intobitcoinops:masterfrom
harding:2019-10-16-newsletter
Oct 16, 2019
Merged

Newsletters: add 68 (2019-10-16)#237
bitschmidty merged 1 commit intobitcoinops:masterfrom
harding:2019-10-16-newsletter

Conversation

@harding
Copy link
Collaborator

@harding harding commented Oct 14, 2019 •
edited by bitschmidty
Loading

  • Check for updated RCs
  • Check for YouTube videos made public

jnewbery
jnewbery reviewed Oct 14, 2019
View reviewed changes
Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of nits.

I've asked Neha and Wassim if they can provide us with the links to the DCI cryptoeconomics summit videos.

_posts/en/newsletters/2019-10-16-newsletter.md Outdated
- [Bitcoin Core #17056][] adds a `sortedmulti` [output script
descriptor][] that sorts the pubkeys provided to it using the
lexicographic order described in [BIP67][]. This makes it possible to
use import xpub-based descriptors for wallets that require using BIP67,
Copy link
Contributor

@jnewbery jnewbery Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/makes it possible to use import/makes it possible to import/

@jnewbery
Copy link
Contributor

jnewbery commented Oct 15, 2019

ACK ea04b57

Just need to check latest RCs before merge.

@jnewbery
Copy link
Contributor

jnewbery commented Oct 15, 2019

Does the newsletter summary also need to be changed now that LND is a release, rather than a release candidate? It currently reads:

This week's newsletter requests testing of several release candidates, relays an update on the taproot proposal, describes a proposed increase...

Perhaps change to:

This week's newsletter announces the newest release of LND, requests testing of release candidates for Bitcoin Core and C-Lightning, relays an update on the taproot proposal, describes a proposed increase...

adamjonas
adamjonas reviewed Oct 16, 2019
View reviewed changes
@moneyball
Copy link
Contributor

moneyball commented Oct 16, 2019

ACK

@bitschmidty bitschmidty force-pushed the 2019-10-16-newsletter branch from 88812d6 to 0257fc0 Compare October 16, 2019 12:33
@bitschmidty
Copy link
Contributor

bitschmidty commented Oct 16, 2019

ACK
(pushed a small casing change to Coldcard and squashed)

Apologies for the late review!

@bitschmidty bitschmidty merged commit 24bb730 into bitcoinops:master Oct 16, 2019
@bitschmidty
Copy link
Contributor

bitschmidty commented Oct 16, 2019

Software from LND, C-Lightning, and Eclair
Enough to make @harding lose his hair!

Please make sure nothings out of whack
Review the taproot BIPs and provide feedback

Everything is broken, lots couldve gone wrong
Despite all of that, Bitcoins still going strong

As always, TY to @harding for authoring and the last minute updates and to @jnewbery @adamjonas and @moneyball for the reviews and feedback

@jnewbery jnewbery added the newsletters Publishing/translating/editing newsletters label Oct 31, 2019
@murchandamus murchandamus mentioned this pull request Jul 17, 2023
Merged
@murchandamus murchandamus mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamjonas adamjonas adamjonas left review comments

@jnewbery jnewbery jnewbery left review comments

Assignees

No one assigned

Labels

newsletters Publishing/translating/editing newsletters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harding @jnewbery @moneyball @bitschmidty @adamjonas