Skip to content

Conversation

harding
Copy link
Collaborator

@harding harding commented Oct 25, 2019

Eight proposed pages for the new /en/topics/ section of the site. Suggested reviewer is @moneyball

Note: tests expected to fail on the final "production" test because of the FIXME link pointing to a topic that's part of a different PR. That's the last test we run, so if it's the only failure, this should be ok.

@jnewbery jnewbery added the topics Topics indexes label Oct 31, 2019
Copy link
Contributor

@moneyball moneyball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed 4 of 8 topics so far.

  • NOINPUT
  • Eltoo
  • Coinjoin
  • Payjoin

@@ -3,6 +3,12 @@
[compatibility matrix]: /en/compatibility/
[optech email]: mailto:info@bitcoinops.org
[rss feed]: /feed.xml
[topic channel factories]: / {% comment %}FIXME: /en/topics/channel-factories/{% endcomment %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is already a FIXME here, so just an additional call out that we need to fix this before publishing

Copy link
Contributor

@moneyball moneyball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I've finished reviewing all 8 of 8 topics!

@moneyball
Copy link
Contributor

tACK 27d986a

@jnewbery jnewbery force-pushed the 2019-10-topic-moneyball branch from 27d986a to d448bf6 Compare November 12, 2019 19:31
@jnewbery
Copy link
Contributor

@jnewbery jnewbery force-pushed the 2019-10-topic-moneyball branch from d448bf6 to afbe8ce Compare November 12, 2019 19:46
@jnewbery
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topics Topics indexes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants