-
Notifications
You must be signed in to change notification settings - Fork 138
Topics: add new topics (moneyball) #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed 4 of 8 topics so far.
- NOINPUT
- Eltoo
- Coinjoin
- Payjoin
_includes/references.md
Outdated
@@ -3,6 +3,12 @@ | |||
[compatibility matrix]: /en/compatibility/ | |||
[optech email]: mailto:info@bitcoinops.org | |||
[rss feed]: /feed.xml | |||
[topic channel factories]: / {% comment %}FIXME: /en/topics/channel-factories/{% endcomment %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is already a FIXME here, so just an additional call out that we need to fix this before publishing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I've finished reviewing all 8 of 8 topics!
tACK 27d986a |
27d986a
to
d448bf6
Compare
d448bf6
to
afbe8ce
Compare
Eight proposed pages for the new
/en/topics/
section of the site. Suggested reviewer is @moneyballNote: tests expected to fail on the final "production" test because of the FIXME link pointing to a topic that's part of a different PR. That's the last test we run, so if it's the only failure, this should be ok.