Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter #5 2018-07-24 #40

Merged
merged 1 commit into from Jul 23, 2018

Conversation

@harding
Copy link
Contributor

harding commented Jul 21, 2018

One link depends merge of: bitcoin-core/bitcoincore.org#576 (alternatively, link can be removed; it's labeled as TODO).

Includes a few helper functions, as discussed last week. Also, this week, I clicked through all the links to make sure they pointed at the right thing (sorry about that last week).

#include <feel_free_to_push_to_my_branch>
Copy link
Contributor

jnewbery left a comment

I've made some minor suggested changes here: jnewbery@4018e8e (in https://github.com/jnewbery/bitcoinops.github.io/commits/pr40.1).

@harding - let me know what you think.

One more item we should add to this or a future newsletter is a link to stack exchange. Murch has provided wording:

Bitcoin Stackexchange is a question and answer platform collecting the best possible answers to every question about Bitcoin. Some of the most knowledgeable people in the space are contributing to the site regularly. It's already a great resource to learn about technical details, but we'd be happy to have your questions and answers there, too.

lang: en
version: 1
---
This week's newsletter includes news about a new method under

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 22, 2018

Contributor

I think "news about a new..." sounds a bit clumsy. I've reworded in my fixup commit.

This comment has been minimized.

Copy link
@harding

harding Jul 23, 2018

Author Contributor

What about "This new week's new newsletter includes new news about a new method"? :-) (I'm going with the version in your commit.)


- Bitcoin Core [0.16.2RC2][] released for testing in preparation for a
maintenance release that will provide bugfixes and backports.
Community testing is highly appreciated. Note, there was no RC1 due

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 22, 2018

Contributor

I've cut some of the detail from the last sentence here.

week, probably as part of a consolidation by an exchange. The average
number of new native segwit outputs created per hour remains
relatively constant, indicating no obvious decrease in adoption.
(Remember that if your service accepts payments to native segwit

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 22, 2018

Contributor

I've reworded this to (I think) make it a bit clearer. Thoughts?

This comment has been minimized.

Copy link
@harding

harding Jul 23, 2018

Author Contributor

I didn't really like my parenthetical version, and I still don't really like the non-parenthetical version, so I'm just going to drop the whole thing. That segwit saves money is well known and I'm sure we'll have better opportunities in the future to mention the amount of savings possible, so it doesn't seem important to include it here.

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 23, 2018

Contributor

That's a shame. I like reminding companies of the benefits of segwit whenever I can!

But you're right, this doesn't need to be here. There will be better opportunities in future.

[Bitcoin Magazine][announce bmag], [Coindesk][announce cdesk], and several
other publications. This wouldn't have been possible without the
support of our founding sponsors and member companies. Thank you!

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 22, 2018

Contributor

Added an item on our first workshop.

This comment has been minimized.

Copy link
@harding

harding Jul 23, 2018

Author Contributor

I love it, thanks! I'm made two small changes: (1) made "Replace-by-fee and Child-pays-for-parent, and Coin Selection" into a list and dropped the title caps, (2) made both lists in this content use the serial comma (a, b, and c) to match the style of the other lists in the newsletter (serial comma is my preferred list punctuation, but if you want to use the non-serial comma in our docs, we can make a style guide).

inputs, and receive back a list of which inputs would be selected by
the Bitcoin Core wallet's coin selection algorithm.

Meeting participants were mostly opposed to providing this feature,

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 22, 2018

Contributor

added "...as an RPC"

This comment has been minimized.

Copy link
@harding

harding Jul 23, 2018

Author Contributor

I reverted this. My read on the discussion is that most discussion participants were against it being in Bitcoin Core whatsoever, and that they additionally thought that (if it was done), it should be done as a library---probably a third-party library. Just to check, I rescanned that discussion; here were the participants:

achow, wumpus, gmaxwell, jonasschnelli, sipa, jnewbery

Here are one comment per person against making it part of Bitcoin Core. Note, I think the comment from sipa might be more a response to wumpus than an opinion of his own.

19:20:06 <gmaxwell> But the argument I was making above is also an argument against a library: pressure to maintain a stable interface to this would be harmful to the project.
19:22:00 <wumpus> it's fine, they can make a library out of it themselves
19:29:53 <jonasschnelli> Agree with wumpus: I guess its a one-day job to extract the coin selection code and create a library out of it...
19:31:58 <sipa> wumpus: perhaps once the code is sufficiently encapsulated, someone else can librarify that and maintain it

So that's either 3/6 or 4/6 participants suggesting whatever it is should be outside of Bitcoin Core, and with 2/6 being strongly opposed to including it in Bitcoin Core. I think that's sufficient opposition that (in the absence of other evidence) we shouldn't hold out hope that this could be part of a Bitcoin Core-provided library.

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 23, 2018

Contributor

Yes, that's fair.

- [#13652][]: The [`abandontransaction`][rpc abandontransaction] RPC has
been fixed to abandon all descendant transactions, not just children.

**Coming attractions:** next week's newsletter will feature a field

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 22, 2018

Contributor

Great teaser! I think this deserves its own section, so changed this to be an h2

**Coming attractions:** next week's newsletter will feature a field
report from Anthony Towns, a developer at Xapo, about how they
consolidated around 4 million UTXOs to prepare for potential future fee
increases.

This comment has been minimized.

Copy link
@jnewbery

jnewbery Jul 22, 2018

Contributor

Added a call to action.

@jnewbery

This comment has been minimized.

Copy link
Contributor

jnewbery commented Jul 22, 2018

(I've also reviewed bitcoin-core/bitcoincore.org#576, so hopefully we can remove the TODO before publication)

@harding harding force-pushed the harding:2018-07-24-newsletter branch from 803583d to e3f3821 Jul 23, 2018
@harding

This comment has been minimized.

Copy link
Contributor Author

harding commented Jul 23, 2018

@jnewbery thanks for the review and the diff. I squashed your diff into my original commit (amending the commit message to credit you) and added a diff with my additional changes.

@jnewbery jnewbery force-pushed the harding:2018-07-24-newsletter branch from e3f3821 to b944ef6 Jul 23, 2018
@jnewbery

This comment has been minimized.

Copy link
Contributor

jnewbery commented Jul 23, 2018

Fixup looks great. Thanks @harding ! I've squashed and pushed.

Before merging:

@moneyball

This comment has been minimized.

Copy link
Contributor

moneyball commented Jul 23, 2018

tACK

Looks great!

Includes suggested changes by John Newbery
@harding harding force-pushed the harding:2018-07-24-newsletter branch from b944ef6 to 008b609 Jul 23, 2018
@harding

This comment has been minimized.

Copy link
Contributor Author

harding commented Jul 23, 2018

I force pushed an amended commit that removes the link to the Bitcoin Core weekly meeting notes, as it looks like that won't be available in time for the newsletter. Diff was:

--- a/_posts/en/newsletters/2018-07-24-newsletter.md
+++ b/_posts/en/newsletters/2018-07-24-newsletter.md
@@ -49,8 +49,8 @@ Bitcoin transactions, and news on several other notable Bitcoin Core merges.
   or anything else), please contact us. We're here to help our member
   companies!
 
-- **Coin selection RPC unlikely:** In Bitcoin Core's [weekly
-  meeting][bcc meeting 7/19], Andrew Chow raised the possibility of
+- **Coin selection RPC unlikely:** In Bitcoin Core's weekly
+  meeting, Andrew Chow raised the possibility of
   creating an RPC that would allow users to pass in information about a
   transaction they wanted to create, including a list of available
   inputs, and receive back a list of which inputs would be selected by
@@ -160,9 +160,6 @@ prepare for potential future fee increases.
 We love getting contributions to the newsletter from member companies. If you'd like
 to share your experiences in implementing better Bitcoin technology, please contact us!
 
-<!-- TODO: depends on merge of https://github.com/bitcoin-core/bitcoincore.org/pull/576 -->
-[bcc meeting 7/19]: https://bitcoincore.org/en/meetings/2018/07/19/
-
 [rand delay]: https://github.com/bitcoin/bitcoin/commit/22f721dbf23cf5ce9e3ded9bcfb65a3894cc0f8c#diff-118fcbaaba162ba17933c7893247df3aR718
 [p2shinfo bech32]: https://p2sh.info/dashboard/db/bech32-statistics?orgId=1
 [consolidate utxos]: https://en.bitcoin.it/wiki/Techniques_to_reduce_transaction_fees#Consolidation
@jnewbery jnewbery merged commit 5781748 into bitcoinops:master Jul 23, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Mar 31, 2019
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Apr 1, 2019
jnewbery added a commit to harding/bitcoinops.github.io that referenced this pull request Apr 2, 2019
jnewbery added a commit that referenced this pull request Apr 2, 2019
Newsletters: add #40 (2019-04-02)
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Apr 2, 2019
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Apr 2, 2019
jnewbery added a commit that referenced this pull request Apr 2, 2019
Newsletter #40: replace ipython with REPL syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.